WIP: Refactor of the thermal task#2609
Draft
jamesmunns wants to merge 14 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a WIP refactor in service of simplifying the current state tracking performed by the thermal task.
Some of this is still Not Great, particularly the places where I pass 2-4 closures into a single function.
However, by pushing most state tracking down into the BSP, I hope to make it easier to Trait-ify the BSP interface and make it easier to build a "host native" thermal loop for testing purposes.
(most of the builds are failing because I've only refactored
cosmoand none of the other bsps yet)