Bring back preview banner#3304
Open
david-crespo wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed the preview had its page titles slightly higher than local dev. Took me a while to notice the entire preview banner was missing. Looks like we broke it in #3178.
Broken: https://console-c5j03m75a-oxidecomputer.vercel.app/
Fixed: https://console-git-fix-preview-banner-oxidecomputer.vercel.app
First commit here is the best version of the fix with the current structure, second commit rearranges things to move the banner out of the main app layout, which is what we always wanted to do anyway, it was just tedious. The diff is better with whitespace changes hidden.