Un-abstract users/groups tabs to silo-only#3300
Merged
david-crespo merged 2 commits intoJul 22, 2026
Merged
Conversation
david-crespo
commented
Jul 22, 2026
| map.set(identityId, roleName) | ||
| } | ||
| } | ||
| return map |
Collaborator
Author
There was a problem hiding this comment.
This is fun, this was actually a bug — it was keeping whatever the last assignment in the policy was instead of the strongest one. Looking into how this is used and whether this is a better way to do it. Yeah I'm pretty sure this is right.
charliepark
approved these changes
Jul 22, 2026
charliepark
left a comment
charliepark
left a comment
Contributor
There was a problem hiding this comment.
Ah, thanks for catching this!
david-crespo
force-pushed
the
silo-user-group-tabs
branch
from
July 22, 2026 20:59
a17f5b6 to
9f11252
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
force-pushed
the
silo-user-group-tabs
branch
from
July 22, 2026 21:46
9f11252 to
56d7a38
Compare
david-crespo
merged commit Jul 22, 2026
02f17df
into
full_user_group_lists_consolidated
7 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initially I think #3211 had users and groups at both the silo and project level and then pared it back to only have it at the silo level, but kept the abstractions used to make it work in both spots. This undoes the abstraction.
Redone from #3298 because I made that one a stack, and it turns out that prevents you from merging it into the underlying one.