Skip to content

fix: Unable to use config value to set smtp_port in email action configuratio... - #636

Open
Roshan931 wants to merge 1 commit into
ovh:masterfrom
Roshan931:prilog/fix-error-email-plugin-validates-smtp-port-smtp-08-21-2026-0896d1
Open

fix: Unable to use config value to set smtp_port in email action configuratio...#636
Roshan931 wants to merge 1 commit into
ovh:masterfrom
Roshan931:prilog/fix-error-email-plugin-validates-smtp-port-smtp-08-21-2026-0896d1

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #542

Root cause

email plugin validates smtp_port/smtp_skip_tls_verify before template evaluation

Changes

  • Skip the strconv strict-parse checks in the email plugin's validConfig when the value still contains a template handle (same convention already used by the http and apiovh plugins), and move the real parsing errors to exec so an invalid runtime-templated value fails the step instead of being silently coerced to 0/false. Added unit tests covering templated and invalid values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to use config value to set smtp_port in email action configuration

1 participant