Repository navigation
fix: pico4-monado applies the factory lens centre offsets with the stock compositor's signs - #25
Merged
Merged
Conversation
…ock compositor's signs, -centerx and +centery: mirrored, they doubled each headset's offset between the eyes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For overpressure/phoenix#63.
The driver applied
lens_center_gosfrom the factory calibration mirrored on both axes compared to PICO OS. The stock compositor's distortion mesh (libpxrcompositor.so) scales the offsets by 0.001 for X and -0.001 for Y and adds them to the panel point, so it puts the lens centre at -centerx, +centery; we used +centerx, -centery. Headsets differ: on one reporter's the two eyes'centerydiffer by 0.33 mm, which the wrong sign doubled into about 0.9° between the eyes. That matches the reported eye strain and the right eye's picture sitting higher. Mine differ by 0.05 mm, which is why it never showed here.Worn on my headset, with the installed driver and a calibration copy (
PICO4_CALIBRATION_DIR):centery: the left eye's picture went down, where stock's would go up.centerx: the left eye's picture went right, where stock's would go left.test_pico4_lensexpects the stock signs and passes. The fixed driver itself hasn't been built and worn yet.