Skip to content

fix: pico4-monado applies the factory lens centre offsets with the stock compositor's signs - #25

Merged
Xenolphthalein merged 1 commit into
mainfrom
fix/lens-centre-signs
Nov 18, 2026
Merged

Xenolphthalein merged 1 commit into
mainfrom
fix/lens-centre-signs

Conversation

@Xenolphthalein

Copy link
Copy Markdown
Contributor

For overpressure/phoenix#63.

The driver applied lens_center_gos from the factory calibration mirrored on both axes compared to PICO OS. The stock compositor's distortion mesh (libpxrcompositor.so) scales the offsets by 0.001 for X and -0.001 for Y and adds them to the panel point, so it puts the lens centre at -centerx, +centery; we used +centerx, -centery. Headsets differ: on one reporter's the two eyes' centery differ by 0.33 mm, which the wrong sign doubled into about 0.9° between the eyes. That matches the reported eye strain and the right eye's picture sitting higher. Mine differ by 0.05 mm, which is why it never showed here.

Worn on my headset, with the installed driver and a calibration copy (PICO4_CALIBRATION_DIR):

  • Left lens centre moved 2 mm along centery: the left eye's picture went down, where stock's would go up.
  • Left lens centre moved 2 mm along centerx: the left eye's picture went right, where stock's would go left.
  • The fixed signs, emulated with the factory offsets negated, against the current ones: no difference I could see. On this headset they're only 0.15–0.2° apart.

test_pico4_lens expects the stock signs and passes. The fixed driver itself hasn't been built and worn yet.

…ock compositor's signs, -centerx and +centery: mirrored, they doubled each headset's offset between the eyes
@Xenolphthalein
Xenolphthalein requested review from a team as code owners November 18, 2026 12:27
@Xenolphthalein
Xenolphthalein merged commit e1e3e7c into main Nov 18, 2026
22 checks passed
@Xenolphthalein
Xenolphthalein deleted the fix/lens-centre-signs branch November 18, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant