Repository navigation
fix: pico4-monado fits the colour room view's lens model only over the angles it shows, so the room no longer wobbles toward the edges - #21
Merged
Conversation
…e angles it shows, so the room no longer wobbles toward the edges The RGB camera's fisheye62 model was fitted to KB4 over rays out to the image's corners (80-90 degrees off axis, up to 12 px off), which the headset never shows; they pulled the fit off inside the view, where its error swung between 0.3 and 1.7 px (worst 2.0 px at 55 degrees) and the room wobbled as points crossed it. Fitted up to 70 degrees it grows smoothly to about 1 px at the view's edge. The room view logs the fit's error at its start. The head tracker's fits stay as they were.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The colour room view wobbled slightly toward the edges of the view when the head moved, while the middle stayed stable (overpressure/phoenix#50).
The RGB camera's lens model (PICO's fisheye62, with tangential terms) is fitted to the KB4 model the compositor takes. The fit used rays out to the image's corners, 80–90° off axis, which the headset never shows and where the fit is up to 12 px off; they pulled it off inside the view. Measured on a headset's own calibration, in pixels of the 1164×874 image the compositor gets, the error swung between 0.3 and 1.7 px from 20° to 55° off axis (worst 2.0 px, 0.26°, at 55°), so points wobbled as they crossed the view.
pico4_tcam_fit_kb4_within()fits over the rays up to a given angle; the colour room view fits up to 70° (PICO4_TCAM_ROOMVIEW_DEG, the view's edge is at about 55–60°). The error now grows smoothly from under 0.1 px in the middle to about 1 px (worst 1.5 px) at 55–60°; what is left is the tangential part, which KB4 cannot express.Worn A/B on the headset, with the built
driver_monado.sobind-mounted against release 17: the new fit is clearly steadier at the edges. Refs overpressure/phoenix#50.