Skip to content

fix: pico4-monado stops the room view's mesh thread in Deactivate, which vrserver ran into after unloading the driver - #20

Merged
Xenolphthalein merged 1 commit into
mainfrom
fix/monado-mesh-thread
Nov 16, 2026
Merged

Xenolphthalein merged 1 commit into
mainfrom
fix/monado-mesh-thread

Conversation

@Xenolphthalein

Copy link
Copy Markdown
Contributor

The room view's depth-mesh thread (monado-steamvr-roomview-mesh.patch) started at Activate and was joined only in the camera's destructor, which never runs. SteamVR unloads driver_monado.so after Deactivate, and the thread, still polling the HMD every 2 ms, then ran in unmapped code: vrserver died with SIGSEGV at SteamVR stops (a thread started by std::thread, its code in the unmapped range above OpenCV's libraries).

Deactivate now also calls DestroyMeshQueues(), which stops and joins the thread and destroys the mesh queues; a later Activate creates them again. The patch is regenerated against Monado 25.1.0 with the earlier patches applied (only its line numbers change otherwise), pkgrel 17.

Checked on the headset with the built driver_monado.so bind-mounted: the old driver's stop crashed vrserver; four stops of sessions publishing depth meshes with the new driver left no vrserver dump, and each new session published its mesh again.

…ich vrserver ran into after unloading the driver

The depth mesh thread started at Activate and was joined only in the camera's destructor, which never
runs: SteamVR unloads driver_monado.so after Deactivate, and the thread, still polling the HMD every
2 ms, then ran in unmapped code. vrserver died with SIGSEGV at SteamVR stops.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant