Repository navigation
fix: pico4-monado stops the room view's mesh thread in Deactivate, which vrserver ran into after unloading the driver - #20
Merged
Conversation
…ich vrserver ran into after unloading the driver The depth mesh thread started at Activate and was joined only in the camera's destructor, which never runs: SteamVR unloads driver_monado.so after Deactivate, and the thread, still polling the HMD every 2 ms, then ran in unmapped code. vrserver died with SIGSEGV at SteamVR stops.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The room view's depth-mesh thread (monado-steamvr-roomview-mesh.patch) started at Activate and was joined only in the camera's destructor, which never runs. SteamVR unloads
driver_monado.soafter Deactivate, and the thread, still polling the HMD every 2 ms, then ran in unmapped code: vrserver died with SIGSEGV at SteamVR stops (a thread started bystd::thread, its code in the unmapped range above OpenCV's libraries).Deactivate now also calls
DestroyMeshQueues(), which stops and joins the thread and destroys the mesh queues; a later Activate creates them again. The patch is regenerated against Monado 25.1.0 with the earlier patches applied (only its line numbers change otherwise), pkgrel 17.Checked on the headset with the built
driver_monado.sobind-mounted: the old driver's stop crashed vrserver; four stops of sessions publishing depth meshes with the new driver left no vrserver dump, and each new session published its mesh again.