fix ZIP timestamps across time zones - #1033
Open
Guflly wants to merge 1 commit into
Open
Conversation
Guflly
marked this pull request as ready for review
July 27, 2026 17:59
Collaborator
|
LGTM
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #902.
ZIP stores modification times as timezone-naive local clock values. Ouch previously treated those values as UTC during extraction and wrote UTC clock values when creating archives, shifting file times by the local UTC offset.
Archive creation now converts filesystem timestamps to the applicable local offset before writing the ZIP timestamp. Extraction resolves the local offset for the stored date and converts that clock value back to the corresponding filesystem timestamp, including historical daylight-saving offsets.
Tests cover a fixed non-UTC offset and the host's actual local offset.
Validation:
cargo test --no-default-features --features unrar,use_zlib,use_zstd_thin(103 passed)rustfmt --edition 2024 --check --config newline_style=Native src/archive/zip.rscargo clippy --bin ouch --no-default-features --features unrar,use_zlib,use_zstd_thin