osbuild/rpm: implement generic env - #2586
Merged
Merged
Conversation
This was referenced Aug 11, 2026
supakeen
added a commit
to supakeen/image-builder
that referenced
this pull request
Aug 11, 2026
Allow use of the experimental flags to set `image-version` and `image-id`. We don't have a good idea yet how to pass these values otherwise and introducing command line flags is too early at this point. This PR is based on top of [1]. [1]: osbuild#2586 Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
added a commit
to supakeen/image-builder
that referenced
this pull request
Aug 11, 2026
Allow use of the experimental flags to set `image-version` and `image-id`. We don't have a good idea yet how to pass these values otherwise and introducing command line flags is too early at this point. This PR is based on top of [1]. [1]: osbuild#2586 Signed-off-by: Simon de Vlieger <[email protected]>
achilleas-k
previously approved these changes
Aug 12, 2026
avitova
previously approved these changes
Aug 12, 2026
avitova
left a comment
avitova
left a comment
Contributor
There was a problem hiding this comment.
lgtm, failures do ont seem to be related, but let's see after the rerun
| } | ||
|
|
||
| // Verify deep copy of GenericEnv map | ||
| if len(clone.GenericEnv) > 0 { |
Contributor
There was a problem hiding this comment.
I believe this condition is not needed, and if the len was 0, ranging over it would not do any iterations, right?
achilleas-k
approved these changes
Aug 18, 2026
avitova
approved these changes
Aug 18, 2026
Bump the minimum osbuild version and the commit used for CI to be able to use the new stage options for the RPM stage. Signed-off-by: Simon de Vlieger <[email protected]>
In [1] I landed changes to support setting arbitrary environment variables during RPM stage execution. This implements settings them in the wrapper in `image-builder`. [1]: osbuild/osbuild#2524 Signed-off-by: Simon de Vlieger <[email protected]>
Update CS9 snapshots to get newer selinux policy, required for osbuild 190.
supakeen
added a commit
to supakeen/image-builder
that referenced
this pull request
Aug 19, 2026
Allow use of the experimental flags to set `image-version` and `image-id`. We don't have a good idea yet how to pass these values otherwise and introducing command line flags is too early at this point. This PR is based on top of [1]. [1]: osbuild#2586 Signed-off-by: Simon de Vlieger <[email protected]>
supakeen
added a commit
to supakeen/image-builder
that referenced
this pull request
Aug 20, 2026
Allow use of the experimental flags to set `image-version` and `image-id`. We don't have a good idea yet how to pass these values otherwise and introducing command line flags is too early at this point. This PR is based on top of [1]. [1]: osbuild#2586 Signed-off-by: Simon de Vlieger <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 1 I landed changes to support setting arbitrary environment variables during RPM stage execution. This implements settings them in the wrapper in
image-builder.Note that I didn't implement the newly added kernel install environment variables; we have no use for them (yet) so I left the struct as is.