Reject duplicate Behavior Annex completion-relative timeouts 馃 - #3276
Merged
Merged
Conversation
Model separate and overlapping multi-source completion-relative timeout declarations, and assert that the duplicate timeout is diagnosed. Include a clean distinct-source control to ensure each complete state may still own one timeout.
Track timeout ownership by each complete source state so a second outgoing completion-relative timeout is diagnosed. Run the uniqueness check for every strict transition expansion while preserving once-per-declaration checks for shared multi-source conditions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3266
Cause and correction
D_4_L2_Checkqueried aMap<BehaviorState, BehaviorTransition>with the entire source-state list, although entries were stored under individual states. Separately written duplicate timeouts therefore never matched. Multi-source conditions are shared across strict transition expansions and intentionally validated once, which also skipped uniqueness checks for non-first sources.The checker now records completion-relative timeout ownership for each expanded complete source state before shared-condition deduplication. Period/value and other declaration-level checks still run once per written condition.
Regression coverage
Issue3266Testvalidates three external model fixtures:The fixtures include the standard diagnostics, resolved-model, source-position, and unparse characterization goldens. Existing covering-syntax goldens now record the two newly detected duplicate timeout transitions.
Validation
Issue3266Test: 3 tests, 0 failures, 0 errorsCoveringSemanticTest: 11 tests, 0 failures, 0 errorsIssue3184Test: 5 tests, 0 failures, 0 errorsorg.osate.ba.testsbundle: 228 tests, 0 failures, 0 errors-Dtycho.localArtifacts=ignore: 143 modules, build successDependencies and residual risk
This PR is based directly on current
masterafter #3274 and #3275 and has no PR dependency. The change is confined to BA legality checking and its regression assets; grammar, metamodel, generated sources, and serialization logic are unchanged.