Repository navigation
Keep the commits added to the regeneration pull request - #2
Merged
Merged
Conversation
A later run rebuilt the branch from main and force-pushed it, dropping a new service's package added on the branch as the pull request asks, and closed the pull request, deleting the branch, when the API had nothing new. It now generates on top of added commits with main merged in, never closes a pull request that has them, and pushes with a lease, so a commit pushed during the run fails it instead of being lost.
Committers count as well as authors, so an amended commit of the workflow's is kept. An unreadable origin fails the run instead of passing for an absent branch. The branch is deleted only as the run found it, under the lease. Conflicts from merging main resolve in what update.sh writes again; any other fails with a message. A fork's pull request from a branch named regenerate is not taken for the workflow's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The regeneration pull request asks for a new service's package, or a generator extension, to be added on its branch. The next daily run then threw that work away: it rebuilt the branch from main and force-pushed it. When the API had nothing new, it closed the pull request and deleted the branch.
Now:
scripts/update.shrewrites anyway are resolved automatically. Any other conflict fails the run with a message to merge main by hand.--force-with-leaseagainst the branch as it found it, so a commit pushed during the run fails the run instead of being lost.regenerateis no longer taken for the workflow's.Tested: