Repository navigation
Regenerate from the latest API - #33
Merged
Merged
Conversation
API: origincloudhq/api@ec8bbdf...992b5bd The generated code is left as it was: see the pull request.
The API now has the iam service (origincloud.iam.v1beta1, at iam.origincloudapis.eu), so `origin iam` is generated and the hand-written group, its GraphQL queries and the identifier types only they used are removed. - commands.toml: iam off `hand_written`; a [[service]] entry for the group's help; a [[retired]] entry for each of the 13 commands no generated command of the same name replaces (create-service-account, list-service-accounts, get-role and list-roles are generated under their names); a [[shown_once]] notice for CreateServiceAccount's client_secret; [[view]]s for RoleBinding, ServiceAccount, Role and Permission, carrying over the columns the hand-written lists had. - `origin id login` still reads the signed-in user from the GraphQL API, since that read applies pending invitations; that query is all that is left of service_apis::iam, and its warning no longer names the retired `origin iam current-user`. - The origincloud-iam SDK crate, the README's groups and CONTRIBUTING.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves to origincloudhq/api@992b5bdeca9c (changes), but generation fails, so this moves the Rust SDK and API_REVISION alone and leaves the generated code as it was. scripts/update.sh said:
Extend the generator (generator/) on this branch, or leave the method or the field out in generator/commands.toml with the reason, and run scripts/generate.sh. Commits added here are kept by later runs, which generate with them.
Retiring the hand-written
origin iamAdded on this branch: main (with #32) merged in, and the switch CONTRIBUTING.md describes, so
origin iamis now the generated group.Removed:
handler/iam/, theIamvariant and its arm, every iam GraphQL query but the current user's, and the identifier types (OrgId,ProjectId,Principal,Urn) only those queries used.Kept:
origin id loginstill reads the signed-in user from the GraphQL API once after a login, because that read applies pending invitations; the RESTGetUserdoesn't. Its warning on a failed read no longer namesorigin iam current-user: it says to log in again or sign in to the console.Views: Show iam members by their email, and the other iam lists by what tells them apart #32's columns, carried over as
[[view]]entries:tablecolumnslist-role-bindingsname,member,role,project,createTimelist-members,principal-grants,current-user-grantslist-service-accountsname,displayName,member,createTime,deleteTimelist-service-accountslist-rolesname,descriptionlist-roleslist-permissionsname,service,resourceType,actionpermissionsA role shows as its id (
owner), a member asuser:{email}.Secret notice:
create-service-accountsays on standard error thatclientSecretis shown this once, ascreate-key-pairdoes forprivateKey([[shown_once]]).Retired: the 13 commands with no generated command of the same name, each with its replacement in
generator/commands.toml.create-service-account,list-service-accounts,get-roleandlist-rolesare generated under the same names; the three invitation commands have no CLI equivalent, since invitations aren't in the API.Checked locally: everything ci.yml runs.