chore(archive): park SWE-bench Benchmark (Beta) UI in .archive - #822
Merged
Chloe-JY merged 1 commit intoAug 16, 2026
Merged
Conversation
Move the benchmark runner UI out of the live build following the .archive convention (paths mirror src/, excluded from tsconfig, restorable by reverse git mv): features/BenchmarkPanel, SidebarModules/Benchmark, the benchmark tab renderer, ChatPanel BenchmarkRunBuilder, store/benchmark, api/tauri/benchmark, the E2E seed helpers and the two E2E specs. Sever the branch in shared code: drop the "benchmark" WorkStation tab type + factory + persisted-type allow-list, the chat-panel BENCHMARK create target and benchmarkSessionGroup surface/content mode, the nav-sidebar coordinator-session routing / child hiding / master-row highlight, the flask-conical session icon override, E2E bootstrap wiring, the wdio docker fixture builder, and creator.benchmark.* i18n keys in 13 locales. Rust src-tauri/src/benchmark and the Housekeeper token benchmark are untouched. See .archive/README.md for the full map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.archive/following the repo's existing convention (paths mirrorsrc/, excluded fromtsconfig, restorable by reversegit mv; full map appended to.archive/README.md).benchmarkWorkStation tab type, the chat-panelBENCHMARKcreate target +benchmarkSessionGroupsurface, the nav-sidebar coordinator-session routing / child-session hiding, theflask-conicalsession icon override, E2E bootstrap wiring,wdiodocker fixture, andcreator.benchmark.*i18n keys in 13 locales.Problem
We do not need the benchmark runner UI for now, but it kept a footprint across the tab store, chat-panel surface state, sidebar connectors, session metadata, i18n and E2E config. On
developit was already effectively unreachable: no menu offered thebenchmarkcreate target, nothing created abenchmarktab except E2E seed helpers,BenchmarkTabSidebarhad no consumer — the only live entry was clicking a legacy "Benchmark run coordinator" session in the sidebar. Dead-but-wired UI still costs typecheck/lint/test time and confuses future refactors (the previous PR moved its hooks around for nothing).Solution
Moved to
.archive/src/…(self-contained):features/BenchmarkPanel/,modules/WorkStation/shared/SidebarModules/Benchmark/,TabContent/renderers/benchmark.tsx,engines/ChatPanel/panels/BenchmarkRunBuilder.tsx,store/benchmark/,api/tauri/benchmark/,app/root/e2e/helpers/benchmark.ts, and the two E2E specs (.archive/tests/e2e/specs/core/).Edited in place to sever:
store/workstation/tabs/{types,tabFactory,storage,index,factories/*}(tab type/factory/allow-list),TabContent/registry.ts,SidebarModules/index.ts,SortableTab(BookLockbranch),CodeSidebarHeaderActions,store/ui/chatPanelAtom.ts+types/ui/chatPanel.ts+chatPanelSurfaceReducer.ts(create target / content mode / surface kind),ChatPanel/{index,ChatPanelContent,ChatPanelEmptyContent,hooks/useChatPanelContentState},NavigationSidebar/connectors/{useWorkstationSidebarHandlers,useSessionMenuItems/*,sidebarConnector.pinnedAndRevealData},util/session/sessionDisplayMetadata.ts,app/root/{E2EBootstrap,e2e/types},tests/e2e/wdio.conf.mjs,i18n/locales/*/sessions.json.Deliberately kept:
src-tauri/src/benchmark/(Rust commands still compile; now unreferenced from the frontend — candidate for a backend-only follow-up), the Housekeeper token benchmark (housekeeperTokenBenchmark,integrations:housekeeper.benchmark.*— a different feature), and the genericflask-conical/folder-benchmarkicon entries.Potential risks
benchmarkWorkStation tab is dropped by the storage allow-list on load (same handling as earlier archived tab types).benchmark_*commands remain registered; nothing calls them from the frontend anymore. Harmless, but dead until removed.Test plan
pnpm typecheck— 0 errors (also gated per commit by the pre-commit hook)pnpm lintoversrc/— 0 errorspnpm test— 1099 files / 8679 tests pass (one exhaustiveness count inworkspaceState.test.tsupdated 39 → 38 for the removed tab type;sessionSidebarRow.test.tsbenchmark-icon case removed with the feature)node --check tests/e2e/wdio.conf.mjsafter removing the docker fixture builderrgfor the archived module paths /benchmarktab-type literal acrosssrc/**→ 0 hits outside the Housekeeper token benchmark and the Rust-command comment inapi/tauri/rpc/schemas/cli.tsSubmit checklist
feat(scope): summaryorfix(scope): summary.