Repository navigation
fix(sparkasse): read the plot area on plot cards - #502
Merged
orangecoding merged 1 commit intoOct 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A Sparkasse plot card (estateTypeGroupingId for Grundstücke) carries "450 m² Grundstücksfläche" in its main facts instead of a living area, so
sizewas always empty for plots and a job's minimum size filter could not apply to them.The size selector now also matches "Grundstücksfläche". A house card can carry both facts, and the parser joins the texts of a multi-match ("120 m² Wohnfläche774 m² Grundstücksfläche"), so a small
readSizepicks the living area when there is one and the plot area only as the fallback. A card with neither (only rooms) still yields null.Test: one case in sparkasse.test.js for house card with both facts, plot card, living-area-only card and a card with only rooms.
Related issue
none
AI disclosure (required)
Fredy accepts AI assisted contributions, but they have to be declared. An
undeclared AI PR will be closed. Tick exactly one box:
ai:none- I wrote this myself. No AI generated code, text or commit messages.ai:assisted- AI helped with parts of it (autocomplete, refactoring, tests, docs). I reviewed and understand every line.ai:generated- AI produced most or all of this PR. I reviewed it, but it is largely machine written.Which AI: Claude Code, Sonnet 5.5
How much: the selector change, the readSize helper and the test were drafted with Claude Code; I checked it against the live Sparkasse plot search, reviewed every line and ran the checks.
Why: I search for plots and the minimum size filter needs a size on them; faster to get the edge cases (card with both facts) enumerated.
Checklist
yarn test:offlinepasses (oryarn testif the change touches a live provider)yarn lintandyarn format:checkpass