Skip to content

fix(sparkasse): read the plot area on plot cards - #502

Merged
orangecoding merged 1 commit into
orangecoding:masterfrom
nmehlei:fix/sparkasse-plot-area
Oct 29, 2026
Merged

orangecoding merged 1 commit into
orangecoding:masterfrom
nmehlei:fix/sparkasse-plot-area

Conversation

@nmehlei

@nmehlei nmehlei commented Oct 28, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

A Sparkasse plot card (estateTypeGroupingId for Grundstücke) carries "450 m² Grundstücksfläche" in its main facts instead of a living area, so size was always empty for plots and a job's minimum size filter could not apply to them.

The size selector now also matches "Grundstücksfläche". A house card can carry both facts, and the parser joins the texts of a multi-match ("120 m² Wohnfläche774 m² Grundstücksfläche"), so a small readSize picks the living area when there is one and the plot area only as the fallback. A card with neither (only rooms) still yields null.

Test: one case in sparkasse.test.js for house card with both facts, plot card, living-area-only card and a card with only rooms.

Related issue

none

AI disclosure (required)

Fredy accepts AI assisted contributions, but they have to be declared. An
undeclared AI PR will be closed. Tick exactly one box:

  • ai:none - I wrote this myself. No AI generated code, text or commit messages.
  • ai:assisted - AI helped with parts of it (autocomplete, refactoring, tests, docs). I reviewed and understand every line.
  • ai:generated - AI produced most or all of this PR. I reviewed it, but it is largely machine written.

Which AI: Claude Code, Sonnet 5.5

How much: the selector change, the readSize helper and the test were drafted with Claude Code; I checked it against the live Sparkasse plot search, reviewed every line and ran the checks.

Why: I search for plots and the minimum size filter needs a size on them; faster to get the edge cases (card with both facts) enumerated.

Checklist

  • yarn test:offline passes (or yarn test if the change touches a live provider)
  • yarn lint and yarn format:check pass
  • The change is useful for everybody, not a custom tweak for my own setup
  • I have read and answered the AI disclosure above honestly

@orangecoding
orangecoding merged commit d1c81bf into orangecoding:master Oct 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants