Repository navigation
Stop stale pool aim packets from showing menu-change errors - #153
Merged
Merged
Conversation
dop42
added
the
needs-in-game-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Normal pool play could show "The table changed. Reopen its menu and try again" when an automatic aim update arrived with the revision from before a shot settled or the balls reracked. The same stale-state guard handled periodic aim packets and explicit menu/shot requests, so a harmless rejected presentation update produced a menu error toast.
Reject stale aiming updates silently while preserving epoch/revision validation and refusal messages for explicit actions. No stale request is accepted and no game state is changed by the notification fix.
Validation: the regression reproduces the unwanted toast before this change, then verifies repeated old-revision and old-epoch aiming updates are rejected without notifications while an explicit stale shot still receives its refusal. Existing full-rack physics, authority, playback and modes audits remain in place. Validation completed: full Lua suite 6,722 checks with zero failures, all 68 audits, Lua syntax, sandbox scan and diff checks pass.
Not yet verified in game: play through shot completion/rerack to confirm no unsolicited reopen-menu toast. No client script, model pack, placement or camera change. MANUAL updated; documentation-site tracking: opx77-framework/opx77_doc#19.