Repository navigation
Fix pool mode selection and long target labels - #146
Merged
Merged
Conversation
dop42
added
the
needs-in-game-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a pool mode closed the menu without requesting a game: the menu treats
close=truerows without their ownactcallback as close-only items, so the pool-level handler never received a selection. Use menu-widecloseOnSelectwith regular action rows, and accept onlyselectcallbacks so confirmation navigation cannot execute commands.Keep long target labels beside their icon, selection count and checkbox in a non-wrapping heading; truncate overflowing labels with an ellipsis while descriptions retain their own line. Rebuild the shipped UI bundle and document both behaviors.
Validation: the new enabled-client regression clicks the actual menu page, checks the emitted create request and feeds back a real match snapshot to verify camera entry; it reproduces the missing request before this change. Callback cost remains below 5,000 instructions. All 68 Lua audits, sandbox scan, UI lifecycle checks, typecheck and build pass. Chromium verified nine target layouts at widths 160/224/320px. Full Lua suite: 6,722 checks, zero failures. GitHub checks must pass before merging.
Not yet verified in game: reconnect and select solo practice to confirm camera entry, then inspect long target labels. Follow-up #142; documentation site tracking: opx77-framework/opx77_doc#19.