Repository navigation
fix(pool): start selected modes after focus release and add menu icons - #145
Merged
Merged
Conversation
dop42
added
the
needs-in-game-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Selecting a pool mode could close the menu without starting the aiming camera. The server ownership packet can arrive before native keyboard capture is released; the input loop then discarded autoAim as though the user had interrupted an active charge. A regression reproduces the failure before the change and passes after it.
Keep a newly accepted mode/turn's first aim pending until native focus clears. Still cancel an already active aim/charge when inventory or another UI captures input, and never turn the held menu-selection click into a shot. Add supported OPX glyphs for mode choices and table actions, including busy and reset-pending rows.
Validation: enabled-client lifecycle regression covers delayed focus release, held click suppression and inventory cancellation; table-menu regression verifies mode/reset/busy icons against the actual shared glyph catalogue. Sandbox checks and diff checks pass. This is a client-only fix; server match rules and asset packages are unchanged. In-game mode-entry retest remains required after reconnecting.
Follow-up #142. Documentation updated in MANUAL and tracked in opx77-framework/opx77_doc#19.