Repository navigation
feat(pool): add game modes, smoother camera and recorded audio - #143
Merged
Merged
Conversation
dop42
added
the
needs-in-game-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool now offers free practice, a shot-limited solo challenge and an explicit two-player duel lobby. Duels use authoritative pocket/scratch scoring, retain/pass turns and end at the configured target or forfeiture. Table reset is available while aiming; duel resets pause shots until the other identity-bound participant accepts, with decline/timeout support. The table menu and overlay show mode, scores, turn, result and available actions.
The overhead camera is lower (1.65 m), middle click replaces V so inventory stays available, the cue-camera offset keeps the shaft visible and release includes a short follow-through. Props explicitly request no collision/physics. Scripted cameras now set thirdPersonBody=true, verified in the signed op77.152 client binary; older-client body/options refusals retry once without the field. Existing camera/control cleanup remains in place.
Real CC0 cue/ball/pocket recordings come from opx_pool_assets >=0.2.0. Server contact IDs/times feed bounded local spatial playback aligned with the ball interpolation timeline; replay/join suppression, mute and voice cleanup are tested. The assets companion also packages Coyote cleanup as the matching archive sidecar, preserving sector guards. No unverified loader or unsecured mode is enabled.
Validation: 6,722 Lua checks; 67 audits plus the new table-menu audit; dedicated tests cover lobby/turn guards, scores/scratches, solo limits, wins, reset consent/timeouts, identity replacement, forfeit, rerack, body fallback, V/MMB isolation, cue collision flags and audio deduplication/timing. Typecheck/build and UI lifecycle tests pass. The companion has eight Python asset tests and a real-code audio ownership/voice-cap test. Requires a fresh client boot; physical camera/head/queue framing, audible mix and two-real-client play remain unverified in game.
Related #142. Documentation updated in MANUAL and opx77-framework/opx77_doc#19. Keep #140 open for live cleanup verification; the logs supplied so far are old (Oct 1–5, ArchiveXL 1.27.1) and do not establish the currently loaded plugin version.