Repository navigation
feat(pool): add guided camera aiming and power gauge - #141
Merged
Merged
Conversation
dop42
added
the
needs-in-game-test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pool practice rendered the balls, but lining up a shot through the normal player view was difficult. Entering now opens a smooth camera behind the cue ball. Mouse movement aims, Shift provides fine control, V switches to a table view and the wheel adjusts camera height. A dashed straight guide ends at the first ball or cushion; a dedicated unfocused gauge shows charge before release. After a shot, the table camera follows authoritative playback and rearms when it settles.
Camera, guide, overlay and module-owned position/control leases are released on cancellation, UI capture, loss of ownership, leaving and stop. A refused/lost camera cancels practice with a friendly notice and keeps the native reason in operator diagnostics. The guide has a 20-line cap and native expiry; the gauge expires stale frames. Server physics, shot validation and economic behavior are unchanged.
Validation: 6,722 Lua checks, 65 audits, typecheck/build and UI lifecycle regressions pass. Camera/guide tests cover world framing, first contact, ownership/refusal cleanup and instruction budgets (enabled frame 1,800; guide 1,900 in native doubles). New natives were checked against Devkit 2.50.0+op77.148; VPS is op77.152. Actual camera framing and input feel still require the user's in-game test.
Stock decorations remain a separate tracked blocker: patches are present but the Cyberpunk 2.5 ArchiveXL loader is not in the verified core manifest or standalone stable index. No security downgrade or unverified executable was enabled by this PR. Documentation is updated in MANUAL and tracked in opx77-framework/opx77_doc#19.
Related: #140 (keep open until the cleanup dependency and live test are resolved).