Use node:assert for tests instead of expect

[achou11]

Exploratory follow-up to #218 (review) to use https://nodejs.org/api/assert.html for the tests.

There were some minor adjustments to the tests. Would argue that many of the basic assert() calls are generally unnecessary given the usage of TypeScript, but changing things like that is not (yet) the focus of this exploration.

[benoit74]

WDYT? Is the change worth it?

I feel like this is a good move, this remove an unneeded library from dependencies at minimal cost for the developer.

[achou11]

WDYT? Is the change worth it?

I feel like this is a good move, this remove an unneeded library from dependencies at minimal cost for the developer.

Yep I generally agree! Can always revisit if the tests get more involved :)

[achou11]

Would argue that many of the basic assert() calls are generally unnecessary given the usage of TypeScript, but changing things like that is not (yet) the focus of this exploration.

Do you want me to address this here or just leave as-is for now?

[achou11]

Would argue that many of the basic assert() calls are generally unnecessary given the usage of TypeScript, but changing things like that is not (yet) the focus of this exploration.

Do you want me to address this here or just leave as-is for now?

@benoit74 bumping this one more time before merging, in case you have any thoughts