Repository navigation
kmscon: wait for the splash, add unifont, depend on evdev - #169
Merged
Merged
Conversation
Started while plymouth holds DRM master, kmscon retries taking it from a timer and logs a failure on every attempt. Its built-in 8x16 font covers the first 256 code points only, held in CP437 order while kmscon looks glyphs up by Unicode code point, so box drawing, block and braille characters come out wrong. The input event nodes it reads only exist with the evdev handler, which nothing pulled in. Do not start the instance while plymouth reports that it holds the display, and start it on the plymouth.release event the splash hands procd when it lets go. Build the GNU Unifont engine into a kmscon-mod-unifont package; its generator genunifont is packaged as a host build, and a patch lets meson use that one. The init script passes --font-engine only when one is configured, so kmscon falls through to unifont when the module is installed. GNU Unifont is dual-licensed under GPL-2.0-or-later with a font embedding exception and OFL-1.1; kmscon takes the font under OFL-1.1, so the module package carries that licence besides MIT. Depend on kmod-input-evdev. Fixes: 3c8ebee ("kmscon: depend on input-support for the evdev nodes") Signed-off-by: Daniel Golle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started while plymouth holds DRM master, kmscon retries taking it from a timer and logs a failure on every attempt. Its built-in 8x16 font covers the first 256 code points only, held in CP437 order while kmscon looks glyphs up by Unicode code point, so box drawing, block and braille characters come out wrong. The input event nodes it reads only exist with the evdev handler, which nothing pulled in.
Do not start the instance while plymouth reports that it holds the display, and start it on the plymouth.release event the splash hands procd when it lets go. Build the GNU Unifont engine into a kmscon-mod-unifont package; its generator genunifont is packaged as a host build, and a patch lets meson use that one. The init script passes --font-engine only when one is configured, so kmscon falls through to unifont when the module is installed. GNU Unifont is dual-licensed under GPL-2.0-or-later with a font embedding exception and OFL-1.1; kmscon takes the font under OFL-1.1, so the module package carries that licence besides MIT. Depend on kmod-input-evdev.
Fixes: 3c8ebee ("kmscon: depend on input-support for the evdev nodes")