Repository navigation
kmscon, seatd: fixes for systems without CONFIG_VT - #168
Merged
Merged
Conversation
Start seatd to manage physical consoles directly in case CONFIG_VT is disabled by passing SEATD_VTBOUND=0 env variable. Signed-off-by: Daniel Golle <[email protected]>
seatd answers CLIENT_OPEN_SEAT by buffering the response and the enable event together, so both reach libseat in one read. libseat parses only the response and leaves the event in its connection buffer, with nothing left on the socket for a client watching the fd to be woken by, so a client that follows the documented contract never activates its seat. Signed-off-by: Daniel Golle <[email protected]>
The seat is enabled while libseat_open_seat() is still running, before uterm_vt_allocate() has installed the callbacks an activation needs, and whatever libseat has buffered is never dispatched because watching its fd for readability yields nothing. kmscon therefore stayed asleep with --libseat: no video device was initialised and the display stayed dark. Carry patches that dispatch libseat once from an idle callback and replay an enable that arrived too early, and that mark an unopened tty as -1 so the backend stops issuing VT ioctls on file descriptor 0. Signed-off-by: Daniel Golle <[email protected]>
Whether a service runs at boot is already expressed by its rc.d symlink, which service enable and service disable maintain. A UCI option saying the same thing is a second source of truth that disagrees with the first as soon as either is touched on its own. Signed-off-by: Daniel Golle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
kmsconandseatdwork on systems running a kernel withoutCONFIG_VT.