Repository navigation
splash fixes - #167
Merged
Merged
splash fixes#167
Conversation
OpenWrt builds the kernel without CONFIG_VT, so BOOT_TTY never exists and plymouth falls back to the first serial device it finds, which is the system console. It opens that console, watches it for input, puts it in raw mode and locks every termios bit, so a shell sharing it loses its cursor keys, its interrupt character and a share of everything typed. Forcing details mode along the way also costs the splash its renderer. Carry a patch that makes --graphical-boot keep plymouth away from a console altogether and pass it from both entry points. The faked "splash" kernel argument and --ignore-serial-consoles go with it, both implied now, as does --attach-to-session, which redirected the console into plymouth's pty with TIOCCONS and stopped kernel messages reaching the serial port. Signed-off-by: Daniel Golle <[email protected]>
ply_pixel_buffer_get_size() reports the logical area while ply_pixel_buffer_get_argb32_data() points at the device pixel buffer. Where the device scale is above one, the plutovg surface then describes the buffer as too narrow and with too short a stride, so each odd logical row lands in the right half of the panel and the image collapses into a fraction of it. The damaged area is handed over in logical coordinates as well, while ply_renderer_head_flush_area() reads it as device pixels. Size the surface in device pixels, scale the canvas by the device scale so a theme keeps drawing in logical coordinates, and report the damaged area in device pixels. Signed-off-by: Daniel Golle <[email protected]>
The preinit hook asked for a splash by appending "splash" to a faked kernel command line and told plymouth to ignore serial consoles, which left it free to take the system console as its terminal anyway. --graphical-boot covers both and keeps plymouth on KMS only. Signed-off-by: Daniel Golle <[email protected]>
plymouth resolves a configured theme as themes/<name>/<name>.plymouth, so the descriptor has to carry the name of its directory. Named openwrt.plymouth it is never found, and plymouth walks its fallback chain down to the built-in text splash, which draws nothing at all on a board that has no text console. Name the descriptor after the theme so the configured theme loads. Signed-off-by: Daniel Golle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various fixes for plymouth boot splash, particularly on devices without
CONFIG_VT.