Repository navigation
treewide: depend on the per-class device support packages - #166
Merged
Merged
Conversation
kmscon reads its keyboard from /dev/input directly through libudev, so it needs the input group and the hotplug rule that input-support ships. It has no libevdev or libinput dependency to inherit that from, unlike the compositors in this feed. The DRM side already comes from libdrm. Signed-off-by: Daniel Golle <[email protected]>
A hardware driver renders through /dev/dri/renderD*, which is 0600 root:root until accel-support allocates the render group and ships the rule that puts the node into it. The software rasterisers are the exception and keep no such dependency: libmesa-softpipe, libmesa-llvmpipe and libvulkan-lvp run on the CPU and open no device. Because the gate sits on each driver, an image built around a software rasteriser stays out of the render group, while one that picks a hardware driver pulls the group in with it. Signed-off-by: Daniel Golle <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
AUDIO_SUPPORTandDISPLAY_SUPPORTtarget features were replaced in openwrt.git by per-class*-supportpackages that allocate the device groups and ship the hotplug rules, merged as openwrt/openwrt#25446. This is the part of that migration which this feed has to state for itself.Most of the feed needs nothing, because the gate travels: openwrt/packages#30651 puts a plain dependency on
libdrmandlibevdev, andpackage/scripts/package-metadata.plre-emits a selected package's own conditions onto whatever selects it. Sowlroots,plymouth,vkmark,libva,kmscube,libcairo,libepoxy,libsdl3and everylibmesa-*provider already inherit what they need. Two things cannot be inherited.kmscon
It reads its keyboard from
/dev/inputdirectly through libudev and has no libevdev or libinput dependency to inherit the gate from, so it namesinput-supportitself. Its DRM side still comes from libdrm.mesa and the render node
A hardware driver renders through
/dev/dri/renderD*, which is0600 root:rootuntilaccel-supportallocates the render group. That dependency goes on each hardware driver, tenlibmesa-*and eightlibvulkan-*.The software rasterisers are deliberately excluded:
libmesa-softpipe,libmesa-llvmpipeandlibvulkan-lvprun on the CPU and open no device. Putting the gate on the individual drivers rather than on the sharedPackage/libmesa/Defaultis what makes that distinction possible, and it has a useful consequence: an image built around a software rasteriser stays out of the render group, while one that picks a hardware driver pulls the group in with it.Measured on the generated Kconfig:
libmesa-softpipe,libmesa-llvmpipevideo-supportonlylibmesa-amd,libmesa-virgl, and the rest of the hardware driversaccel-supportandvideo-supportkmsconinput-supportandvideo-support