modemmanager: fix user in custom initial EPS bearer settings - #30372
modemmanager: fix user in custom initial EPS bearer settings#30372osedlbauer wants to merge 1 commit into
Conversation
The proto handler reads the init_user option but references the undefined variable init_username when building the connect args, so the username is never passed to mmcli. Signed-off-by: Oliver Sedlbauer <[email protected]>
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The rename looks correct and complete: all three sites (proto_config_add_string, the local declaration and json_get_vars) are updated consistently, and init_username is the name already used both by README.md:62-63 and by LuCI's protocol/modemmanager.js:189,`` so this aligns the proto handler with the documented and UI-exposed option rather than the other way around. Since the old init_user value was read but never used, no working configuration regresses. `PKG_RELEASE` bump is correct for a files-only change.
One optional nit inline; nothing blocking.
Generated by Claude Code
|
|
||
| # Give the modem time to change to the initializing state after | ||
| # unlocking | ||
| # unlocking |
There was a problem hiding this comment.
nit: this trailing-whitespace cleanup is unrelated to the init_user → init_username rename and isn't mentioned in the commit message. Harmless, but it makes the commit do more than its subject/body describes — either drop it or add a line to the commit body saying a stray trailing space is removed along the way.
Generated by Claude Code
2 participants
📦 Package Details
Maintainer: @feckert
Description:
The proto handler reads the init_user option but references the undefined variable init_username when building the connect args, so the username is never passed to mmcli.