kadnode: update to 2.4.2 - #30342
Open
mwarning wants to merge 1 commit into
Open
Conversation
Formality Check: Suggestions AvailableWe checked this pull request against the contribution guidelines. Here is what needs your attention:
|
Minor version update with bugfixes. Signed-off-by: Moritz Warning <[email protected]>
openwrt-ai
reviewed
Aug 21, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed 1 new commit; no blocking issues found.
Checks performed against upstream: the v2.4.2 tag exists in mwarning/KadNode (e3d2617, peeled to commit 11acc78), PKG_RELEASE correctly stays at 1 for a version bump, and nothing in the v2.4.1..v2.4.2 range breaks the packaging — no CLI option was removed (only --bob-print-keys added), the build/kadnode output path and the FEATURES= interface are unchanged, and --version still prints the feature list that files/kadnode.init greps for cmd. The upstream Makefile churn in that range only touches the nss feature, which this package does not enable.
One optional, pre-existing packaging note inline.
Generated by Claude Code
| PKG_VERSION:=2.4.2 | ||
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE_PROTO:=git |
Collaborator
There was a problem hiding this comment.
nit (optional, pre-existing — not a blocker for this bump): the feed guidelines ask for PKG_SOURCE_PROTO:=git only as a last resort when no release archive is available. KadNode publishes tags (v2.4.2 resolves upstream), so this could move to a tarball fetch via the @GITHUB mirror macro with PKG_HASH instead of PKG_SOURCE_VERSION + PKG_MIRROR_HASH, which also removes the need to regenerate a mirror tarball on every release. Since that changes the download scheme, it is better done as its own commit rather than folded into this version bump.
Generated by Claude Code
Contributor
Author
|
I have tried to use these lines to use the source package download instead of git: But I get this error message: No idea how to fix it right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📦 Package Details
Maintainer: @mwarning
Description:
Bugfixes.
🧪 Run Testing Details
✅ Formalities