sshtunnel: explicitly set $HOME to /root in init script - #30053
sshtunnel: explicitly set $HOME to /root in init script#30053supersonic-copycat wants to merge 2 commits into
/root in init script#30053Conversation
Formality Check: FailedWe checked this pull request against the contribution guidelines. Here is what needs your attention: 🛑 CRITICAL ERRORS
|
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit. The change itself is sound (setting HOME=/root so dropbear's ssh client can find known_hosts). One inline indentation nit noted. Commit message/formality issues (missing sshtunnel: subject prefix, Signed-off-by, real author name/email) are already covered by the openwrt bot's formality check.
Generated by Claude Code
fix format: use tabs instead of spaces Co-authored-by: OpenWrt AI review account <[email protected]> Signed-off-by: supersonic-copycat <[email protected]>
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed 1 new commit (ef90c28). It applies the tab-indentation fix from the previous round and changes nothing else — the functional diff is still the single procd_set_param env HOME="/root" line, which is a correct fix for dbclient not finding ~/.ssh/known_hosts under procd (procd does not set HOME, and the service runs as root, whose home is /root).
One patch-hygiene nit inline. The remaining commit-metadata items (subject prefix, author name/e-mail, Signed-off-by) and the PKG_RELEASE bump are already reported by the formality bot, so I am not repeating them here. Nothing found that blocks a merge on the code itself.
Generated by Claude Code
| " | ||
|
|
||
| procd_open_instance "$server" | ||
| procd_set_param env HOME="/root" |
There was a problem hiding this comment.
nit: the indentation is fixed now, thanks. Since ef90c28 only re-indents the line that b83e718 added, the two commits are an introduce-then-fix pair — please squash them into a single commit (git rebase -i, then git push --force-with-lease --force-if-includes). That also lets you give the resulting commit a proper subject; Update net/sshtunnel/files/sshtunnel.init is the GitHub web-editor default and does not describe the change.
Generated by Claude Code
|
This pull request has been marked stale because it has the "not following guidelines" label and has seen no activity for 14 days. |
|
This pull request was closed because it had been marked stale for 14 days with no activity. If you would like to continue working on it, fix the reported issues and ask a maintainer to reopen it — or open a new pull request with the updated changes. |
|
Hi @supersonic-copycat, are you able to fix squash your commits and add the proper commit message or at least a Signed-off-by line with real e-mail address? |
📦 Package Details
Maintainer: @nunojpg
Description
When dropbear is used as ssh client, it looks for
known_hostsat$HOME/.ssh/known_hosts. If $HOME is not set,known_hostscannot be found and ifStrictHostKeyCheckingis enabled, connection fails. This happened before #5559I created new issue to track (#30050)
🧪 Run Testing Details
✅ Formalities
If your PR contains a patch:
git am