Skip to content

sshtunnel: explicitly set $HOME to /root in init script - #30053

Open
supersonic-copycat wants to merge 2 commits into
openwrt:masterfrom
supersonic-copycat:sshtunnel-fix
Open

sshtunnel: explicitly set $HOME to /root in init script#30053
supersonic-copycat wants to merge 2 commits into
openwrt:masterfrom
supersonic-copycat:sshtunnel-fix

Conversation

@supersonic-copycat

Copy link
Copy Markdown

📦 Package Details

Maintainer: @nunojpg

Description

When dropbear is used as ssh client, it looks for known_hosts at $HOME/.ssh/known_hosts. If $HOME is not set, known_hosts cannot be found and if StrictHostKeyChecking is enabled, connection fails. This happened before #5559
I created new issue to track (#30050)


🧪 Run Testing Details

  • OpenWrt Version: 25.12.4
  • OpenWrt Target/Subtarget: mediatek/filogic
  • OpenWrt Device: xiaomi ax3000t

✅ Formalities

  • I have reviewed the CONTRIBUTING.md file for detailed contributing guidelines.

If your PR contains a patch:

  • It can be applied using git am
  • It has been refreshed to avoid offsets, fuzzes, etc., using
    make package/<your-package>/refresh V=s
  • It is structured in a way that it is potentially upstreamable

@openwrt

openwrt Bot commented Jul 20, 2026

Copy link
Copy Markdown

Formality Check: Failed

We checked this pull request against the contribution guidelines. Here is what needs your attention:

🛑 CRITICAL ERRORS

Commit b83e718 - explicitly set $HOME to /root:

  • Author name format is invalid ('supersonic-copycat'). Please set your full name (first and last, e.g. 'Jane Doe').
  • Committer name format is invalid ('supersonic-copycat'). Please set your full name (first and last, e.g. 'Jane Doe').
  • Author email must not be a GitHub noreply address ('[email protected]'). Please use a real email address that is linked to your GitHub account.
  • Committer email must not be a GitHub noreply address ('[email protected]'). Please use a real email address that is linked to your GitHub account.
  • Commit subject must start with <package name or prefix>:
  • Commit description body is empty or contains only trailers (e.g. Signed-off-by). Please provide a meaningful description of what this change does and why
  • Missing 'Signed-off-by:' line. Please add a line at the end of the commit message in the format 'Signed-off-by: Your Name [email protected]', matching your commit author or committer identity.

Commit ef90c28 - Update net/sshtunnel/files/sshtunnel.init:

  • Author name format is invalid ('supersonic-copycat'). Please set your full name (first and last, e.g. 'Jane Doe').
  • Author email must not be a GitHub noreply address ('[email protected]'). Please use a real email address that is linked to your GitHub account.
  • Commit subject must start with <package name or prefix>:
  • Signed-off-by email must not be a GitHub noreply address ('[email protected]'). Please use a real email address that is linked to your GitHub account.

⚠️ STYLISTIC WARNINGS & SUGGESTIONS

Package Release Audit:

  • ⚠️ Content changed in these packages, but without a PKG_RELEASE or version bump:

    • net/sshtunnel

    Increment PKG_RELEASE by 1 (or bump PKG_VERSION/PKG_SOURCE_DATE and reset PKG_RELEASE to 1) so users receive the update.

Do not increment release for minor changes. Cosmetic edits (e.g., typos in comments, copyright updates, formatting/whitespace), changing the package maintainer (PKG_MAINTAINER), or updating source download info (PKG_SOURCE_URL / PKG_HASH) do not require incrementing PKG_RELEASE.

Tip

Do not close this pull request to make corrections. Instead, modify your existing commits (e.g. git commit --amend) and update the branch using git push --force-with-lease --force-if-includes. The checks will re-run automatically.


Something broken? Consider reporting an issue.
Running version 3eeda58 deployed on 2026-08-18 11:06:29 CEST

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit. The change itself is sound (setting HOME=/root so dropbear's ssh client can find known_hosts). One inline indentation nit noted. Commit message/formality issues (missing sshtunnel: subject prefix, Signed-off-by, real author name/email) are already covered by the openwrt bot's formality check.


Generated by Claude Code

Comment thread net/sshtunnel/files/sshtunnel.init Outdated
fix format: use tabs instead of spaces

Co-authored-by: OpenWrt AI review account <[email protected]>
Signed-off-by: supersonic-copycat <[email protected]>

@openwrt-ai openwrt-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 new commit (ef90c28). It applies the tab-indentation fix from the previous round and changes nothing else — the functional diff is still the single procd_set_param env HOME="/root" line, which is a correct fix for dbclient not finding ~/.ssh/known_hosts under procd (procd does not set HOME, and the service runs as root, whose home is /root).

One patch-hygiene nit inline. The remaining commit-metadata items (subject prefix, author name/e-mail, Signed-off-by) and the PKG_RELEASE bump are already reported by the formality bot, so I am not repeating them here. Nothing found that blocks a merge on the code itself.


Generated by Claude Code

"

procd_open_instance "$server"
procd_set_param env HOME="/root"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the indentation is fixed now, thanks. Since ef90c28 only re-indents the line that b83e718 added, the two commits are an introduce-then-fix pair — please squash them into a single commit (git rebase -i, then git push --force-with-lease --force-if-includes). That also lets you give the resulting commit a proper subject; Update net/sshtunnel/files/sshtunnel.init is the GitHub web-editor default and does not describe the change.


Generated by Claude Code

@openwrt openwrt Bot added the stale label Aug 14, 2026
@openwrt

openwrt Bot commented Aug 14, 2026

Copy link
Copy Markdown

This pull request has been marked stale because it has the "not following guidelines" label and has seen no activity for 14 days.
It will be closed if nothing happens within another 14 days. Updating your commits to fix the reported issues will remove the stale label automatically.

@openwrt

openwrt Bot commented Aug 29, 2026

Copy link
Copy Markdown

This pull request was closed because it had been marked stale for 14 days with no activity.

If you would like to continue working on it, fix the reported issues and ask a maintainer to reopen it — or open a new pull request with the updated changes.

@openwrt openwrt Bot closed this Aug 29, 2026
@nunojpg nunojpg self-assigned this Aug 29, 2026
@nunojpg nunojpg reopened this Aug 29, 2026
@openwrt openwrt Bot removed the stale label Aug 29, 2026
@nunojpg

nunojpg commented Aug 29, 2026

Copy link
Copy Markdown
Member

Hi @supersonic-copycat, are you able to fix squash your commits and add the proper commit message or at least a Signed-off-by line with real e-mail address?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants