make a few anchors with 'role="button"' respond to space - #3096
make a few anchors with 'role="button"' respond to space#3096Alex-Jordan wants to merge 1 commit into
Conversation
|
This was the last item Claude found for accessibility concerns with webwork2. The only unaddressed item after all these PRs is the one about PDF harcopies not being tagged. |
6515df4 to
a54cc71
Compare
drgrice1
left a comment
drgrice1
left a comment
There was a problem hiding this comment.
As I am saying with all of these JavaScript changes, please change the forEach usage to for of loops.
Then this pull request is good.
a54cc71 to
4578b53
Compare
|
OK, they are now "for of" loops. |
somiaj
left a comment
somiaj
left a comment
There was a problem hiding this comment.
Looks good.
I see the same JS code is added in multiple files. Would it be worth adding this to system.js and adding a class that can be used for other pages as well if there are other buttons in the future on other pages you want to respond to space?
|
I had the same thought, but decided not to ask that at this point. It would be good though. |
Co-Authored-By: Claude Sonnet 5 <[email protected]>
4578b53 to
095c5d3
Compare
|
OK, now the duplicate code is in |
3 participants
No description provided.