Cpr

[Peter-J-Freeman]

No description provided.

[John-F-Wagstaff]

Please undo the last commit.

As we discussed before I am currently working on splitting the large commits in the 'regex_removal' branch, and doing review changes as I go. We don't want them to touch at all until that is finished, this will totally break the history or force me to throw away all of the existing work and give up on doing that, if you keep it in.

[codecov]

Codecov Report

❌ Patch coverage is 89.84375% with 78 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.87%. Comparing base (e53f061) to head (0f8d864).

Files with missing lines	Patch %	Lines
VariantValidator/modules/hgvs_utils.py	90.09%	22 Missing ⚠️
VariantValidator/modules/vvMixinCore.py	89.65%	21 Missing ⚠️
VariantValidator/modules/mappers.py	79.31%	18 Missing ⚠️
VariantValidator/modules/vvMixinInit.py	69.23%	8 Missing ⚠️
VariantValidator/modules/utils.py	94.35%	7 Missing ⚠️
VariantValidator/modules/vvDBGet.py	92.30%	1 Missing ⚠️
VariantValidator/modules/vvDatabase.py	94.73%	1 Missing ⚠️

Additional details and impacted files

@@                Coverage Diff                @@
##           regex_removal     #882      +/-   ##
=================================================
- Coverage          84.91%   84.87%   -0.05%     
=================================================
  Files                 48       48              
  Lines              14589    14186     -403     
=================================================
- Hits               12388    12040     -348     
+ Misses              2201     2146      -55     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Peter-J-Freeman]

Please undo the last commit.

As we discussed before I am currently working on splitting the large commits in the 'regex_removal' branch, and doing review changes as I go. We don't want them to touch at all until that is finished, this will totally break the history or force me to throw away all of the existing work and give up on doing that, if you keep it in.

OOPS, I jumped the gun on resolving conflicts. Sorry. Now reverted last commit

[John-F-Wagstaff]

unfortunately reverting in this way leaves it in the history, I have no idea about how this will interact with my edit's but it is not a clean removal.

It is required and recommended to use revert in projects with more coders, or on public branches that others are using. But this is because doing otherwise will clobber the history, and break any patches authored between the initial commit and the revert. Thankfully this is not the case here. Instead we want to just delete the two last commits and do a force push to reset the HEAD on this branch before them.

(If you have a currently clean version of the branch then the code is git reset --hard HEAD~1, twice, once for the revert commit and once for the merge commit that got reverted, followed by a forced push, but I also make a backup branch before doing this kind of thing because '--hard' is exactly what it says and deletes whole commits changes and all)

[Peter-J-Freeman]

OK, I'll look into it in the morning and sort it. Apologies again

[Peter-J-Freeman]

(If you have a currently clean version of the branch then the code is git reset --hard HEAD~1, twice, once for the revert commit and once for the merge commit that got reverted, followed by a forced push, but I also make a backup branch before doing this kind of thing because '--hard' is exactly what it says and deletes whole commits changes and all)

Done