Optimise VariantValidator caching and document configuration - #880
Conversation
|
Clean commit to replace the pull request #877 The code is cleaned, cache settings moved to the settings.py so they can easily be adapted and toggled on and off, including using Environment Variables |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## regex_removal #880 +/- ##
=================================================
+ Coverage 84.84% 84.89% +0.05%
=================================================
Files 48 48
Lines 14554 14586 +32
=================================================
+ Hits 12348 12383 +35
+ Misses 2206 2203 -3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Regression tests added. Required hgvs dup to delins conversion in vvMixinConverters.py
| vvhgvs.global_config.uta.pool_max = 25 | ||
| vvhgvs.global_config.formatting.max_ref_length = 1000000 | ||
|
|
||
| if settings.vvHGVS_HDP_CACHE: |
There was a problem hiding this comment.
We probably want a default setting here, or to not set at all (and rely on the vvhgvs default) and only set to 0 when we override it to 0 explicitly, otherwise we just flipped the default from 100 to 0.
There was a problem hiding this comment.
good point.
vvHGVS_HDP_CACHE is 200 by default. Before this patch, setting caching to False would remove the cache all together. This patch restores the default level when vvHGVS_HDP_CACHE = False
|
@John-F-Wagstaff , can this be merged now? |
John-F-Wagstaff
left a comment
John-F-Wagstaff
left a comment
There was a problem hiding this comment.
This looks OK now, we may want to do some re-arranging later, but this works.
2 participants
No description provided.