STOR-3001: Add TLS scanner job to local-storage-operator - #82673
Conversation
Adds an optional, manually-triggered TLS scanner presubmit job (tls-scanner-local-storage) to local-storage-operator across main, release-4.23, release-5.0, and release-5.1 branches. The job provisions an AWS cluster, installs the operator through OLM, and scans the openshift-local-storage namespace.
openshift-ci-robot
added
the
jira/valid-reference
|
@RomanBednar: This pull request references STOR-3001 which is a valid jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughOpenShift CI configurations add a ChangesLocal storage TLS scanning
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant tls_scanner_local_storage
participant optional_operators_ci_aws
participant tls_13
participant tls_scanner_run
tls_scanner_local_storage->>optional_operators_ci_aws: start optional AWS workflow
optional_operators_ci_aws->>tls_13: run TLS 1.3 adherence check
tls_13->>tls_scanner_run: pass scan namespace and policy
tls_scanner_run->>tls_scanner_local_storage: report scanner result
Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml`:
- Around line 101-121: Regenerate the Prow job artifacts for the
tls-scanner-local-storage test by running make update. Commit the generated
output for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml
lines 101-121, and add the corresponding generated jobs for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml
lines 101-121,
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml
lines 102-122, and
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml
lines 101-121.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: a69a0722-4ee3-4d24-b3de-de74d9caf12c
⛔ Files ignored due to path filters (4)
ci-operator/jobs/openshift/local-storage-operator/openshift-local-storage-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0-presubmits.yamlis excluded by!ci-operator/jobs/**ci-operator/jobs/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (4)
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yamlci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yamlci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yamlci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml
| - always_run: false | ||
| as: tls-scanner-local-storage | ||
| optional: true | ||
| steps: | ||
| cluster_profile: openshift-org-aws | ||
| dependencies: | ||
| OO_INDEX: ci-index-local-storage-operator-bundle | ||
| env: | ||
| OO_CHANNEL: preview | ||
| OO_INSTALL_NAMESPACE: openshift-local-storage | ||
| OO_PACKAGE: local-storage-operator | ||
| OO_TARGET_NAMESPACES: '!install' | ||
| SCAN_NAMESPACE: openshift-local-storage | ||
| SCANNER_CPU: "1" | ||
| SCANNER_MEMORY: 1Gi | ||
| TLS_13_ENABLE_TLS_ADHERENCE: "true" | ||
| TLS_13_TLS_ADHERENCE_POLICY: StrictAllComponents | ||
| test: | ||
| - ref: tls-13 | ||
| - ref: tls-scanner-run | ||
| workflow: optional-operators-ci-aws |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Regenerate Prow jobs for all newly added scanner jobs. These named tests alter generated Prow-job configuration, but no generated artifacts are included.
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml#L101-L121: runmake updateand commit generated output.ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml#L101-L121: include the release-4.23 generated job.ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml#L102-L122: include the release-5.0 generated job.ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml#L101-L121: include the release-5.1 generated job.
📍 Affects 4 files
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml#L101-L121(this comment)ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml#L101-L121ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml#L102-L122ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml#L101-L121
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml`
around lines 101 - 121, Regenerate the Prow job artifacts for the
tls-scanner-local-storage test by running make update. Commit the generated
output for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-main.yaml
lines 101-121, and add the corresponding generated jobs for
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-4.23.yaml
lines 101-121,
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.0.yaml
lines 102-122, and
ci-operator/config/openshift/local-storage-operator/openshift-local-storage-operator-release-5.1.yaml
lines 101-121.
Source: Coding guidelines
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
A total of 36 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dfajmon, RomanBednar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/pj-rehearse ack |
|
@RomanBednar: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
@RomanBednar: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary by CodeRabbit
Adds an optional, manually triggered TLS 1.3 scanner presubmit job for
local-storage-operatoracrossmain,release-4.23,release-5.0, andrelease-5.1. The job provisions an AWS cluster, installs the operator through OLM, and scans theopenshift-local-storagenamespace using the TLS scanner tool with configured resource limits and adherence policies.