Skip to content

NO-JIRA: add TLS scan jobs for HCO - #82659

Open
nunnatsa wants to merge 1 commit into
openshift:mainfrom
nunnatsa:hco-tls-scan
Open

NO-JIRA: add TLS scan jobs for HCO#82659
nunnatsa wants to merge 1 commit into
openshift:mainfrom
nunnatsa:hco-tls-scan

Conversation

@nunnatsa

@nunnatsa nunnatsa commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Adds optional Azure and AWS TLS scan jobs to the HCO OpenShift CI configuration. The jobs install HCO, enable PQC/TLS scanning in the kubevirt-hyperconverged namespace, and use cloud-specific workflows, with AWS additionally enabling spot instances and KVM emulation.

Signed-off-by: Nahshon Unna Tsameret <[email protected]>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 30, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@nunnatsa: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from avlitman and orenc1 July 30, 2026 09:11
@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nunnatsa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2026
@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ed08dd0b-dc1a-44cd-bfb7-ff7d8e0bdb8e

📥 Commits

Reviewing files that changed from the base of the PR and between b5946f8 and 80f7c3f.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main.yaml

Walkthrough

Adds optional Azure and AWS CI jobs for HCO TLS scanning, including scanner configuration, cloud-specific deployment settings, test references, and operator SDK workflows.

Changes

HCO TLS scanning

Layer / File(s) Summary
Cloud TLS scan jobs
ci-operator/config/kubevirt/hyperconverged-cluster-operator/kubevirt-hyperconverged-cluster-operator-main.yaml
Adds optional Azure and AWS jobs that deploy the custom resource and run TLS scanner tests with cloud-specific profiles, workflows, and environment settings. AWS additionally enables spot instances and KVM emulation.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding TLS scan jobs for HCO.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR only adds static CI job/config names and reusable TLS refs; no Ginkgo titles or dynamic identifiers were introduced.
Test Structure And Quality ✅ Passed PR only changes ci-operator YAML job configs; no Ginkgo test files or test code were modified, so the checklist is not applicable.
Microshift Test Compatibility ✅ Passed PR only adds ci-operator TLS scan job YAML; no new Ginkgo tests or MicroShift-unsafe API usage was introduced.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds ci-operator/job YAML for TLS scan jobs; no new Ginkgo e2e tests or test code changes, so no SNO assumptions to assess.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator/prow job config changed; no deployment manifests, operator code, or controllers, and no node selectors/affinity/spread/PDB logic added.
Ote Binary Stdout Contract ✅ Passed Only CI/prow YAML changed; no process-level binary code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only adds CI job definitions; no new Ginkgo test code or IPv4/public-internet assumptions are introduced.
No-Weak-Crypto ✅ Passed Adds TLS scan jobs only; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret/token comparisons found.
Container-Privileges ✅ Passed The added TLS scan jobs only define env, refs, and deploy steps; no privileged:true, hostPID/hostNetwork/hostIPC, SYS_ADMIN, or allowPrivilegeEscalation fields are present.
No-Sensitive-Data-In-Logs ✅ Passed The added TLS scan jobs only set CI env and run make/tls refs; no new log statements or secret/PII exposures appear in the changed config.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@nunnatsa: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws kubevirt/hyperconverged-cluster-operator presubmit Presubmit changed
pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure kubevirt/hyperconverged-cluster-operator presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@nunnatsa

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@nunnatsa

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@nunnatsa: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

@nunnatsa: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/kubevirt/hyperconverged-cluster-operator/main/hco-tls-scan-azure 80f7c3f link unknown /pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-azure
ci/rehearse/kubevirt/hyperconverged-cluster-operator/main/hco-tls-scan-aws 80f7c3f link unknown /pj-rehearse pull-ci-kubevirt-hyperconverged-cluster-operator-main-hco-tls-scan-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants