AGENT-1533: Increase time for agent ha5 test by bfournie · Pull Request #82635 · openshift/release

bfournie · 2026-07-29T17:36:20Z

The agent-ha5-dualstack-iso-no-registry occasionally times out before the installation is complete. This job takes longer for the 5 control plane nodes to resolve. Increase the timeout.

Summary by CodeRabbit

Updated the nightly OpenShift CI job e2e-agent-ha5-dualstack-iso-no-registry-techpreview in ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml to set DEVSCRIPTS_SETUP_TIMEOUT: 150m, giving the 5CONTROL_IPV4V6 install more time to complete during ISO no-registry setup.
Enhanced the Baremetal dev-scripts setup step (ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh) to use a configurable DEVSCRIPTS_SETUP_TIMEOUT (default 130m) by deriving:
- MAKE_TIMEOUT for the dev-scripts make target, and
- SSH_TIMEOUT for the SSH session as MAKE_TIMEOUT + 45m.
Documented the new DEVSCRIPTS_SETUP_TIMEOUT knob in ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-ref.yaml.

openshift-ci-robot · 2026-07-29T17:36:25Z

@bfournie: This pull request references AGENT-1533 which is a valid jira issue.

Details

In response to this:

The agent-ha5-dualstack-iso-no-registry occasionally times out before the installation is complete. This job takes longer for the 5 control plane nodes to resolve. Increase the timeout.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bfournie · 2026-07-29T17:36:42Z

/cc @andfasano

openshift-ci · 2026-07-29T17:37:26Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bfournie
Once this PR has been reviewed and has the lgtm label, please assign stbenjam for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

coderabbitai · 2026-07-29T17:37:34Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: a06ac167-25b5-4279-b758-f885affb1e41

📥 Commits

Reviewing files that changed from the base of the PR and between 9f19344 and b3955b8.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (3)

ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-ref.yaml

Walkthrough

Dev-scripts setup now accepts configurable timeouts, defaults to 130 minutes, and adds a 45-minute SSH buffer. The nightly e2e-agent job overrides the setup timeout to 150 minutes, while an adjacent four-hour job timeout is removed.

Changes

Dev-scripts setup timeout

Layer / File(s)	Summary
Timeout contract and execution `ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-ref.yaml`, `ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh`	Defines `DEVSCRIPTS_SETUP_TIMEOUT` with a `130m` default, validates it, applies it to the make step, and derives the SSH timeout with a 45-minute buffer.
Nightly job timeout override `ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml`	Sets the e2e-agent job’s setup timeout to `150m` and removes the preceding job’s `4h0m0s` timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant NightlyJob
  participant DevscriptsSetup
  participant SSHSession
  participant MakeTarget
  NightlyJob->>DevscriptsSetup: Pass DEVSCRIPTS_SETUP_TIMEOUT=150m
  DevscriptsSetup->>SSHSession: Apply setup timeout plus 45m
  SSHSession->>MakeTarget: Execute make target with 150m timeout

Suggested labels: rehearsals-ack

Suggested reviewers: dgoodwin, wking, andfasano

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: increasing timeout for the agent ha5 test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No Ginkgo test titles were added or edited; the PR only changes CI timeout/config files and shell timeout plumbing.
Test Structure And Quality	✅ Passed	PR only changes CI job config and devscripts timeout plumbing; no Ginkgo test code was added or modified, so the check is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only adjusts timeout/config for existing baremetalds devscripts jobs, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests were added; the PR only changes CI config and dev-scripts timeouts, so SNO compatibility review is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only CI timeout/env changes and dev-scripts timeout logic were added; no nodeSelector, affinity, tolerations, or topology-aware scheduling code was introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes CI config and a shell step script; no OTE binary process-level stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No Ginkgo tests were added or modified; changes only adjust CI/job timeouts and dev-scripts setup env/script.
No-Weak-Crypto	✅ Passed	Only timeout/env changes were introduced; no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons appear in the edits.
Container-Privileges	✅ Passed	Touched YAMLs only change timeout/env; scans found no privileged, hostPID/Network/IPC, allowPrivilegeEscalation, or root securityContext additions in manifests.
No-Sensitive-Data-In-Logs	✅ Passed	PR only adjusts timeouts and docs; no new logging or sensitive-data output was added, and existing log handling redacts secrets.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands.}

bfournie · 2026-07-29T17:41:16Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh`:
- Around line 196-198: Update the timeout handling around MAKE_TIMEOUT and
SSH_TIMEOUT to enforce or document that DEVSCRIPTS_SETUP_TIMEOUT must use
minute-based values. Prefer normalizing supported duration inputs before adding
the 45-minute SSH buffer, while preserving the existing MAKE_TIMEOUT value
passed to make.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: c4a5670e-69f0-4551-be96-ee060f89631e

📥 Commits

Reviewing files that changed from the base of the PR and between 2d95403 and 51a198a.

⛔ Files ignored due to path filters (1)

ci-operator/jobs/openshift/release/openshift-release-main-periodics.yaml is excluded by !ci-operator/jobs/**

📒 Files selected for processing (3)

ci-operator/config/openshift/release/openshift-release-main__nightly-5.0.yaml
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh
ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-ref.yaml

openshift-merge-bot · 2026-07-29T17:44:42Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-29T17:48:31Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

openshift-merge-bot · 2026-07-29T17:53:33Z

@bfournie: your /pj-rehearse request was not processed because the request waited in queue for longer than 5 minutes. Please retry in a few minutes.

bfournie · 2026-07-29T17:55:08Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-ha5-dualstack-iso-no-registry-techpreview

openshift-merge-bot · 2026-07-29T17:56:55Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

bfournie · 2026-07-29T18:19:54Z

/pj-rehearse periodic-ci-openshift-release-main-nightly-5.0-e2e-agent-compact-iso-no-registry-techpreview

openshift-merge-bot · 2026-07-29T18:19:56Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-ci · 2026-07-29T20:23:32Z

@bfournie: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bfournie · 2026-07-29T21:36:11Z

/pj-rehearse ack

openshift-merge-bot · 2026-07-29T21:36:14Z

@bfournie: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

andfasano · 2026-07-30T16:07:50Z

 ref:
  as: baremetalds-devscripts-setup
  from: dev-scripts
  grace_period: 10m


The step doesn't define an explicit timeout, so as per the current docs it's defaulted to 2h. This means that any internal timeout (in the script) will be clipped to the external step timeout by ci-operator.
So, to keep supporting the internal script timeout, I think it will be anyhow required to define a larger step timeout, ie 3h, so that the internal timeout could be properly honored (right now, it is not, because currently the step timeout overrides it completely).
Not sure if such change may introduce any regression (different error codes?) in case of timeout, it may be worth trying

Good point @andfasano. Added a explicit 3h timeout to baremetalds-devscripts-setup

The agent-ha5-dualstack-iso-no-registry occasionally times out before the installation is complete. This job takes longer for the 5 control plane nodes to resolve. Increase the timeout.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 29, 2026

openshift-ci Bot requested a review from andfasano July 29, 2026 17:36

openshift-ci Bot requested review from dgoodwin and wking July 29, 2026 17:37

coderabbitai Bot reviewed Jul 29, 2026

View reviewed changes

Comment thread ci-operator/step-registry/baremetalds/devscripts/setup/baremetalds-devscripts-setup-commands.sh Outdated

bfournie force-pushed the increase-agent-ha5-timeout branch from 51a198a to 9f19344 Compare July 29, 2026 17:47

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 29, 2026

andfasano reviewed Jul 30, 2026

View reviewed changes

AGENT-1533: Increase time for agent ha5 test

b3955b8

The agent-ha5-dualstack-iso-no-registry occasionally times out before the installation is complete. This job takes longer for the 5 control plane nodes to resolve. Increase the timeout.

bfournie force-pushed the increase-agent-ha5-timeout branch from 9f19344 to b3955b8 Compare July 30, 2026 16:23

Uh oh!

Conversation

bfournie commented Jul 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 29, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

coderabbitai Bot commented Jul 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

openshift-ci Bot commented Jul 29, 2026

Uh oh!

bfournie commented Jul 29, 2026

Uh oh!

openshift-merge-bot Bot commented Jul 29, 2026

Uh oh!

andfasano Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

bfournie Jul 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bfournie commented Jul 29, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 29, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 29, 2026 •

edited

Loading