OCPBUGS-90560: remove GCP boot disk image defaulting from admission webhook - #1525
OCPBUGS-90560: remove GCP boot disk image defaulting from admission webhook#1525nader-ziada wants to merge 1 commit into
Conversation
Stop setting disk.Image at admission time so the GCP provider actuator can resolve it dynamically at reconcile time using the coreos-bootimages ConfigMap and machine architecture. Add RBAC for the machine-api-controllers SA to read the coreos-bootimages ConfigMap in the MCO namespace. Signed-off-by: Nader Ziada <[email protected]>
|
@nader-ziada: This pull request references Jira Issue OCPBUGS-90560, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (2)
WalkthroughThe webhook no longer defaults GCP disk images, and related fixtures are updated. New RBAC resources grant machine API controllers read access to the ChangesGCP disk image defaulting
Machine API RBAC
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: can't load config: unsupported version of the configuration: "" See https://golangci-lint.run/docs/product/migration-guide for migration instructions Comment |
|
/cc @RadekManak |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This PR should only merge after openshift/machine-api-provider-gcp#181 |
|
@nader-ziada: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Stop setting disk.Image at admission time so the GCP provider actuator can resolve it dynamically at reconcile time using the coreos-bootimages ConfigMap and machine architecture. Add RBAC for the machine-api-controllers SA to read the coreos-bootimages ConfigMap in the MCO namespace.
related to openshift/machine-api-provider-gcp#181
Summary by CodeRabbit
New Features
Bug Fixes