OCPBUGS-122924: Default IngressController to Modern TLS

[redhat-chai-bot]

What

• Set the generated default IngressController TLS security profile to Modern for greenfield installations.
• Preserve the existing upgrade behavior.
• Update the relevant installer unit test.

Validation

• ./hack/go-fmt.sh .
• go test ./pkg/asset/manifests -run '^TestGenerateDefaultIngressController$' -count=1
• git diff --check

Jira

• OCPBUGS-122924

---

AI-generated. Review for accuracy.

@Miciah requested in Slack thread

Summary by CodeRabbit

• Enhancements
  • Default ingress controllers now use the Modern TLS security profile, providing updated secure connection settings across supported platforms.

[openshift-ci-robot]

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-122924, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What

• Set the generated default IngressController TLS security profile to Modern for greenfield installations.
• Preserve the existing upgrade behavior.
• Update the relevant installer unit test.

Validation

• ./hack/go-fmt.sh .
• go test ./pkg/asset/manifests -run '^TestGenerateDefaultIngressController$' -count=1
• git diff --check

Jira

• OCPBUGS-122924

---

AI-generated. Review for accuracy.

@Miciah requested in Slack thread

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

We couldn't safely recover the incremental review. No full review was started, and the last reviewed checkpoint was preserved. Retry later, or explicitly request a full review by commenting @coderabbitai full review.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 620649ca-1f55-46f1-9d31-79d236c8731b

📥 Commits

Reviewing files that changed from the base of the PR and between 43ef4b6 and 2939d8d.

📒 Files selected for processing (2)

• pkg/asset/manifests/ingress.go
• pkg/asset/manifests/ingress_test.go

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

📝 Walkthrough

Walkthrough

The default ingress controller now includes a Modern TLS security profile. The ingress manifest test verifies that the profile exists and uses TLSProfileModernType.

Changes

Default ingress TLS configuration

Layer / File(s)	Summary
Configure and validate the TLS profile pkg/asset/manifests/ingress.go, pkg/asset/manifests/ingress_test.go	Generated default ingress controllers set TLSSecurityProfile.Type to TLSProfileModernType. The test verifies that the profile is present and configured correctly.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 2939d

New installations receive the intended Modern TLS profile, while existing upgrade handling remains unchanged. No merge-blocking risk was found.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely identifies the main change: configuring the default IngressController to use the Modern TLS security profile.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request does not add or modify any dynamic test title. The changed test remains TestGenerateDefaultIngressController, and its table-driven t.Run names are static strings such as `other pl…
Test Structure And Quality	✅ Passed	PASS: The pull request does not add or modify Ginkgo test code. pkg/asset/manifests/ingress_test.go uses Go testing, t.Run, and Testify assertions. The test performs in-memory asset generation a…
Microshift Test Compatibility	✅ Passed	PASS: The pull request changes only ingress manifest generation and a standard Go unit test. The changed test uses testing.T and testify/assert; it adds no Ginkgo It, Describe, Context, or `…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only pkg/asset/manifests/ingress.go and a standard testing unit test in pkg/asset/manifests/ingress_test.go. It adds no Ginkgo It, Describe, Context, or When e2e…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request changes only the generated IngressController TLS profile and its unit test. The production diff adds Spec.TLSSecurityProfile.Type = TLSProfileModernType; it adds no replicas, …
Ote Binary Stdout Contract	✅ Passed	PASS: The PR changes only pkg/asset/manifests/ingress.go and its unit test. The added code assigns TLSSecurityProfile and checks the generated object; it does not write to stdout or configure proc…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS — The pull request adds only a standard Go unit-test assertion in pkg/asset/manifests/ingress_test.go. The changed test uses testing.T and testify/assert, not Ginkgo e2e constructs. It adds…
No-Weak-Crypto	✅ Passed	The PR changes only IngressController configuration and its unit test. It adds configv1.TLSProfileModernType; it does not add MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom cryptography, or secret…
Container-Privileges	✅ Passed	The pull request changes only the generated IngressController TLS profile and its unit test. The added fields are TLSSecurityProfile and TLSProfileModernType. The authoritative diff introduces no priv…
No-Sensitive-Data-In-Logs	✅ Passed	PASS — The pull request adds only a Modern TLS profile to generated IngressController manifests and a test assertion. The reviewed additions contain no logging calls, log messages, credentials, tokens…

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dtantsur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@redhat-chai-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.