WIP: [release-4.21] SPLAT-2866: Add vSphere multi vCenter Day 2 support

[vr4manta]

SPLAT-2866

Changes

• Changed package used for generating vSphere cloud config to match 3CMO so there are no differences (prevents MCO from thinking bootstrap config doesn' t match initial MC generated at operator's first start)
• Enhanced cloud config generation logic to include node network cidr information
• Removed FeatureGateVSphereMultiNetworks check since its been GA for a while now
• Modified vSphere cloud config to not set port for vCenter if not configured in install-config

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2710: Added vSphere day 2 support #10529
• SPLAT-2795: Enhanced vSphere cloud config to include node network cidr information #10614

Since the original PRs require changes to API and library-go, we need to make sure to update the references here to point to the release-4.21 variants to make sure we do not pull in new functionality.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci-robot]

@vr4manta: This pull request references SPLAT-2866 which is a valid jira issue.

Details

In response to this:

SPLAT-2866

Changes

• Changed package used for generating vSphere cloud config to match 3CMO so there are no differences (prevents MCO from thinking bootstrap config doesn' t match initial MC generated at operator's first start)
• Enhanced cloud config generation logic to include node network cidr information
• Removed FeatureGateVSphereMultiNetworks check since its been GA for a while now
• Modified vSphere cloud config to not set port for vCenter if not configured in install-config

Notes

This PR is backporting the following PRs in relation to the vSphere multi vCenter day 2 support feature:

• SPLAT-2710: Added vSphere day 2 support #10529
• SPLAT-2795: Enhanced vSphere cloud config to include node network cidr information #10614

Since the original PRs require changes to API and library-go, we need to make sure to update the references here to point to the release-4.21 variants to make sure we do not pull in new functionality.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0e3620b4-d251-468f-89ab-c57f1d2952c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jhixson74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[vr4manta]

/test all

[openshift-ci]

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/gcp-custom-endpoints-proxy-wif	25d59d3	link	false	/test gcp-custom-endpoints-proxy-wif

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.