Skip to content

OCPBUGS-114428: Bump google.golang.org/protobuf to v1.36.12 - #1230

Open
redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12
Open

redhat-chai-bot wants to merge 2 commits into
openshift:mainfrom
redhat-chai-bot:bot/ocpbugs-114428-protobuf-v1.36.12

Conversation

@redhat-chai-bot

@redhat-chai-bot redhat-chai-bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

Warning

Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Summary by CodeRabbit

  • Chores
    • Updated an indirect dependency to a newer patch version, incorporating upstream maintenance updates.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Sep 14, 2026
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Advanced

Run ID: 1b6291f8-893c-425a-8b62-27ff530fce90

📥 Commits

Reviewing files that changed from the base of the PR and between 7fa0a80 and 3bd5a13.

⛔ Files ignored due to path filters (1)
  • go.sum is excluded by !**/*.sum
📒 Files selected for processing (1)
  • go.mod
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • openshift/console (manual)

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📜 Recent review details
🧰 Additional context used
📓 Path-based instructions (1)
Supply chain security (prodsec-skills): New deps: justify need, check license compatibility Pin exact versions; verify hashes where supported Flag known CVEs (cross-ref osv.dev) No pre-release or yanked versions in production SBOM: ensure b...

⚙️ CodeRabbit configuration file

Files:

  • go.mod
🔀 Multi-repo context openshift/console

Linked repositories findings

openshift/console

  • Console pins google.golang.org/protobuf at v1.36.11 in go.mod:34, while the PR updates the operator to v1.36.12. [::openshift/console::]
  • Console directly uses protojson in pkg/olm/lifecycle.go:16; no changed API or configuration contract was found. [::openshift/console::]
🔇 Additional comments (1)
go.mod (1)

116-116: LGTM!


Walkthrough

The pull request updates the indirect google.golang.org/protobuf dependency from v1.36.10 to v1.36.12 in go.mod.

Changes

Dependency Update

Layer / File(s) Summary
Update protobuf dependency
go.mod
The pinned indirect google.golang.org/protobuf version changes from v1.36.10 to v1.36.12.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: jhadvig

Merge Risk: ⚪ Minimal · up to 3bd5a

The protobuf dependency bump is limited to version metadata and is ready to merge.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the dependency update and limited scope, but it omits the required template sections for analysis/root cause, solution description, test setup, test cases, browser conformance, … Complete every required section in the repository template. For this dependency-only change, state the root cause, describe the dependency update, document validation and test cases, mark browser conformance as not applicable or provide res…
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the Jira issue and the primary change: updating google.golang.org/protobuf to v1.36.12.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds its checksums. It changes no Ginkgo tests or test titles, so it in…
Test Structure And Quality ✅ Passed PASS: The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds matching checksums. No Ginkgo test files or test code change…
Microshift Test Compatibility ✅ Passed PASS. The authoritative pull-request diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds checksums. No Go files or new Ginkgo tests are change…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The review-scoped diff changes only go.mod and go.sum. It adds no Ginkgo tests or other test code, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed PASS. The review-scoped diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksums. It does not add or modify deployment manif…
Ote Binary Stdout Contract ✅ Passed PASS. The authoritative pull-request diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksums. No Go source, OTE suite setup…
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS. The reviewed range changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds matching checksums. No Ginkgo tests or test code changed, so thi…
No-Weak-Crypto ✅ Passed PASS. The review-scoped diff changes only go.mod and go.sum. It updates the indirect protobuf dependency from v1.36.10 to v1.36.12 and adds checksums. No changed line contains MD5, SHA1, DES, RC4, Blo…
Container-Privileges ✅ Passed PASS. The authoritative pull-request diff changes only go.mod and go.sum. It updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksum entries. No container or Kubern…
No-Sensitive-Data-In-Logs ✅ Passed PASS. The pull request changes only go.mod and go.sum. The diff updates google.golang.org/protobuf from v1.36.10 to v1.36.12 and adds the matching checksums. It does not change source code, logging ca…
Full details: Description check

Explanation

The description states the dependency update and limited scope, but it omits the required template sections for analysis/root cause, solution description, test setup, test cases, browser conformance, additional information, and reviewers or assignees.

Resolution

Complete every required section in the repository template. For this dependency-only change, state the root cause, describe the dependency update, document validation and test cases, mark browser conformance as not applicable or provide results, and provide reviewer or assignee information.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 14, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-114428, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bump google.golang.org/protobuf to v1.36.12. Dependency-only; no builder or unrelated changes. Validation passed; changes are limited to go.mod and go.sum.


AI-generated. Review for accuracy.

@Prashanth684 requested in Slack thread

[!WARNING]
Content scanning did not attest this change.
The scanner could not produce a verdict for the pushed content (never_attempted), so it has not been checked for credentials or malware.
Content scanning currently fails open, so this did not hold the change request for review — please review the diff with that in mind.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign jhadvig for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci

openshift-ci Bot commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

@redhat-chai-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images dcd53f5 link true /test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants