OCPBUGS-105406: pkg: Drop conditionals around default-enabled ImageStreamImportMode feature gate

[wking]

With openshift/api@42f4458500 (openshift/api#2266) having enabled the feature gate by default last November, we no longer have to be conditional about whether or not the gate is enabled here. We can just assume it is always enabled.

Summary by CodeRabbit

• Bug Fixes

  • Release architecture metadata is now preserved when synchronizing cluster version status, including when the related feature gate is not enabled.
  • Available update information now consistently reports update and conditional-update architectures as stored.

• Changes

  • Removed the StatusReleaseArchitecture feature gate and associated status tracking. Architecture information is no longer cleared based on this gate.
  • Updates and conditional updates now retain their architecture metadata consistently across status synchronization.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-105406, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

With openshift/api@42f4458500 (openshift/api#2266) having enabled the feature gate by default last November, we no longer have to be conditional about whether or not the gate is enabled here. We can just assume it is always enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 47d1ccb7-5bc6-45a4-8407-e9665bf5c347

📥 Commits

Reviewing files that changed from the base of the PR and between a1e4829 and aab6f4c.

📒 Files selected for processing (1)

• pkg/cvo/status_test.go

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

Walkthrough

The CVO removes the release architecture status feature gate. Available updates and ClusterVersion status now preserve architecture metadata without gate-dependent clearing. Test helpers no longer implement the removed gate.

Changes

Release architecture status

Layer / File(s)	Summary
Remove feature-gate tracking pkg/featuregates/featuregates.go	The gate checker interface, state, accessor, defaults, and gate parsing no longer track release architecture status.
Preserve architecture metadata pkg/cvo/availableupdates.go, pkg/cvo/status.go, pkg/cvo/status_test.go	NeedsUpdate no longer accepts the gate argument. Status synchronization retains stored architecture values. Test helpers no longer expose the removed gate.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to aab6f

This change removes obsolete test-only feature-gate plumbing after release architecture status handling became unconditional. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 13 | ❌ 2

❌ Failed checks (2 warnings)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title describes changes to the ImageStreamImportMode feature gate, but the changes remove the StatusReleaseArchitecture gate and preserve release architecture metadata.	Update the title to describe the removal of StatusReleaseArchitecture conditionals and the retention of release architecture metadata.
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (13 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The pull request changes no Ginkgo test titles. The only test-file change is removal of the statusReleaseArchitecture field and method from fakeRiFlags in pkg/cvo/status_test.go. The authoritati…
Test Structure And Quality	✅ Passed	The check is not applicable to the pull request changes. The only changed test file, pkg/cvo/status_test.go, uses standard testing.T tests, not Ginkgo. Its diff only removes the unused `statusRele…
Microshift Test Compatibility	✅ Passed	The pull request changes only four existing CVO implementation and unit-test files. The diff adds no Ginkgo e2e tests and introduces no new It, Describe, Context, or When test. Therefore, the …
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS: The pull request changes only four existing Go files. The authoritative diff adds no Ginkgo e2e tests or It/Describe/Context/When constructs. The changed test file only removes fields and a meth…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS: The pull request modifies only CVO update/status handling, feature-gate interfaces, and related test code. The authoritative diff adds no manifests or scheduling constructs such as replicas, aff…
Ote Binary Stdout Contract	✅ Passed	No OTE Binary Stdout Contract failure was introduced. The authoritative diff changes only CVO library logic, feature-gate state, and a test helper. Added lines contain no stdout writes, logging calls,…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes four Go files and adds no new Ginkgo tests. The only test-file change removes a fake feature-gate field and method. No added lines contain IPv4 assumptions or external c…
No-Weak-Crypto	✅ Passed	The pull request changes only update-status and feature-gate handling. The added lines contain no MD5, SHA-1, DES, 3DES, RC4, Blowfish, ECB, custom cryptography, or secret/token comparisons. The diff …
Container-Privileges	✅ Passed	PASS. The pull request changes only four Go source/test files. The diff contains no Kubernetes manifests or container security settings. No added lines introduce privileged: true, hostPID, `hostNe…
No-Sensitive-Data-In-Logs	✅ Passed	The pull request introduces no logging calls or log message content. The changed lines only remove a feature-gate parameter and preserve release architecture data in status objects. Existing logs rema…

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wking]

/jira refresh

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-105406, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@wking: This pull request references Jira Issue OCPBUGS-105406, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

With openshift/api@42f4458500 (openshift/api#2266) having enabled the feature gate by default last November, we no longer have to be conditional about whether or not the gate is enabled here. We can just assume it is always enabled.

Summary by CodeRabbit

• Bug Fixes

• Release architecture metadata is now preserved when synchronizing cluster version status, including when the related feature gate is not enabled.

• Available update information now consistently reports update and conditional-update architectures as stored.

• Changes

• Removed the StatusReleaseArchitecture feature gate and associated status tracking. Architecture information is no longer cleared based on this gate.

• Updates and conditional updates now retain their architecture metadata consistently across status synchronization.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@wking: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-update	aab6f4c	link	true	/test verify-update
ci/prow/gofmt	aab6f4c	link	true	/test gofmt
ci/prow/okd-scos-images	aab6f4c	link	true	/test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.