Conversation
- Port cluster updates tab with two-column layout - Add visual channel graph with update timeline - Add update status component with all states - Add cluster update modal for version selection - Add more updates modal for intermediate versions - Add update history tab with table - Port supporting components (CurrentVersion, CurrentChannel, ReleaseNotesLink) - Add cluster update utilities and helpers - Add MachineConfigPool model and hooks - Show cluster ID, desired image, and upstream config - All CSS uses plugin prefix and PatternFly variables - Matches Cluster Settings page layout Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Implement MCP pausing/resuming in ClusterUpdateModal - Full update: resumes all paused MCPs - Partial update: pauses selected worker/custom MCPs - Uses Promise.all to patch ClusterVersion and MCPs together - Add UpdateInProgress component - Shows cluster operators update progress - Shows control plane nodes progress - Shows worker nodes progress - Shows custom pool nodes progress - Live progress bars with percentage - Move Cluster Update nav item above Cluster Settings - Add insertBefore property to console-extensions.json - Update actually triggers cluster update now Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Remove cluster-update-plugin__settings__section wrapper - Use plain DescriptionList with utility classes - Matches console layout (no border on details below graph) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Move cluster details outside bordered container - Bordered container now only wraps two-column layout - Cluster details (ID, image, upstream) have no border - Matches console layout exactly Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Remove left margin from cluster details section - Now left-aligned with the border of the box above - Matches console layout Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Add ClusterChannelModal for editing update channel - Dropdown for available channels - Text input when no channels available - Shows potential channel names as helper text - Add ConfigureUpstreamModal for editing upstream server - Radio buttons for Default vs Custom - Default shows Red Hat update service URL - Custom allows entering custom update service URL - Validation for custom URL - Make channel editable with pencil icon - Make upstream configuration editable with pencil icon - Always shows (not conditional on upstreamURL) - Shows 'Default' when no custom upstream configured - Both modals patch ClusterVersion on save - Match console implementation exactly Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Remove warning alert about missing AgenticRun CRD - Conditionally render 'Updates plan' and 'Active update plans' tabs - Only show when agenticRunsAvailable is true - Conditionally show 'Tech preview' label - Only show when AI features are available - Update page description based on feature availability - Shows AI-focused description when available - Shows traditional update description otherwise - Adjust tab indices dynamically - With AI: tabs 0-3 (Cluster updates, Updates plan, Active plans, History) - Without AI: tabs 0-1 (Cluster updates, Update history) - Provides graceful degradation when AgenticRun CRD not installed Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Contributor
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: spadgett The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Port ClusterVersion mock data from console with multiple test scenarios: - clusterVersionWithUpdates (has available updates) - clusterVersionUpgradeableFalse (blocked by Upgradeable=False) - clusterVersionUpdating (update in progress) - clusterVersionUpToDate (no updates available) - clusterVersionWithNotRecommendedUpdates (has conditional updates) - Add comprehensive tests for 18 utility functions: - getSortedAvailableUpdates, hasAvailableUpdates, hasNotRecommendedUpdates - getClusterUpdateStatus, getAvailableClusterChannels - getDesiredClusterVersion, getClusterVersionChannel - getLastCompletedUpdate, getCurrentVersion - getConditionUpgradeableFalse, getClusterID - getDesiredImage, getUpstreamURL, getReleaseNotesLink - clusterIsUpToDateOrUpdateAvailable - getNewerMinorVersionUpdate, isMinorVersionNewer - Add K8sResourceConditionStatus enum to SDK mock All 51 tests pass, covering edge cases like missing data, invalid versions, and various cluster states. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
- Install @testing-library/react, jest-dom, user-event, and dom - Install jest-environment-jsdom for React component testing - Update Jest config to use jsdom test environment - Add setup file for jest-dom matchers - Add CSS module mock for style imports Component tests added: - UpdateStatus.test.tsx (3 tests): - Renders 'Available updates' when updates available - Renders 'Up to date' when cluster is up to date - Renders update in progress message when updating - UpdatesGraph.test.tsx (6 tests): - Renders current and newest versions - Shows '+ More' button when >2 updates available - Calls onShowMoreUpdates callback when clicked - Shows intermediate version when exactly 2 updates - Handles Upgradeable=False blocking scenario All 116 tests pass (107 unit + 9 component tests). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Test files added: - ClusterChannelModal.test.tsx (6 tests): - Modal open/close behavior - Channel dropdown display - Successful channel update via k8sPatch - Error handling - Cancel functionality - ConfigureUpstreamModal.test.tsx (8 tests): - Modal rendering - Default vs Custom radio button selection - Switching between Default and Custom - Submitting custom URL - Submitting default (null) - Validation for empty custom URL - Error handling - ClusterUpdateModal.test.tsx (12 tests): - Modal open/close behavior - Current and target version display - Full cluster update vs Control plane only update options - Update type selection - Successful full update submission - Error handling - Cancel functionality - Upgradeable=False handling (patch updates only) - Irreversibility warning display - UpdateInProgress.test.tsx (9 tests): - Cluster operators progress display - Control plane nodes progress - Worker nodes progress - Custom pool progress - Graceful handling of missing master/worker pools - Empty cluster operators handling Updated SDK mock: - Added useK8sWatchResource and useAccessReview mocks All 149 tests pass (107 unit + 42 component tests). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Member
Author
|
🤖 Code Analysis by Claude Code I analyzed the relationship between the ported cluster updates code and the original openshift/console implementation. Here's what was directly copied vs adapted: Direct Ports (Minimal Changes)These components were copied nearly verbatim, with only minor adaptations for the plugin environment: 1. Utility Functions (
|
| Aspect | Console | Plugin |
|---|---|---|
| File structure | Monolithic cluster-settings.tsx (1975 lines) |
Split into focused components |
| Lightspeed integration | Optional feature flag | Core feature with graceful degradation |
| Update workflow | Standard update flow | AI proposal workflow |
| CSS | co- prefix classes |
cluster-update-plugin__ prefix |
| Icons | Custom console icons (BlueArrowCircleUpIcon) |
Standard PatternFly icons |
| Navigation | Part of admin settings with breadcrumbs | Standalone plugin page with tabs |
Summary
- ~60-70% directly ported - The core cluster update logic (utility functions, modals, status display) is nearly identical to console code
- ~20-30% adapted - Components like UpdatesGraph and UpdateInProgress were extracted from console's monolithic file and made standalone
- ~10-20% new - The AI update plan workflow, proposal management, and tab structure are unique to the plugin
The ported code is production-tested console code, which is why it's solid. The main value-add of the plugin is the Lightspeed integration and the cleaner, focused UX around cluster updates.
Since the plugin runs within console, we can link to the ClusterVersion details page with the conditions hash. This matches the console implementation and provides a way for users to see full condition details. Changes: - Add ClusterVersionConditionsLink component that links to the ClusterVersion details page in console with #conditions hash - Add conditions link to ReleaseNotAccepted, Updating, ErrorRetrieving, and Failing status messages - Create react-router mock to avoid TextEncoder issues in jest tests Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The console implementation includes a "Cancel update" button when the cluster version is invalid. This allows users to recover from an invalid state by removing the spec.desiredUpdate field. Changes: - Add cancelUpdate function that patches ClusterVersion to remove spec/desiredUpdate - Show "Cancel update" button in InvalidMessage with loading state - Display inline error alert if cancel operation fails - Use getErrorMessage utility for error handling Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports the cluster updates UI from the console's Cluster Settings page to the cluster-update-console-plugin. This provides a standalone, traditional cluster update experience that works independently of the AI-driven update planning features.
What's Included
Core Cluster Updates Tab
Modals
Additional Features
Technical Details
cluster-update-plugin__)Files Changed
src/components/cluster-updates/*- core update UI componentssrc/components/modals/Cluster*Modal.tsx- update modalssrc/utils/cluster-updates.ts- update utilities and helperssrc/models/machineconfigpool.ts- MCP model and typesScreenshots
TODO / Future Work
🤖 Generated with Claude Code