[DRAFT] Experimental revert of #2920 — payload upgrade test

[redhat-chai-bot]

Reverts #2920

Experimental revert — do NOT merge. This draft PR tests whether reverting the OLMLifecycleAndCompatibility feature gate promotion resolves the 4.22→5.0 major upgrade failures in the aggregated-aws-ovn-upgrade-5.0-major blocking job.

Failure pattern: config-operator never sets Progressing=True during major upgrade, causing CVO invariant config-operator must go Progressing=True during an upgrade to fail. The CVO sync loop restarts extend the wait beyond 3 minutes.

Stream blocked: 5.0 CI — 5 consecutive rejections, 38+ hours blocked (last accepted: 5.0.0-0.ci-2026-07-23-195533).

Payload jobs will be triggered on this PR to validate.

---

@stbenjam requested in Slack thread

[openshift-ci]

Hello @redhat-chai-bot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[redhat-chai-bot]

/payload-job periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b6ce61db-1922-48ba-802a-2579af519cef

📥 Commits

Reviewing files that changed from the base of the PR and between 18550f1 and 61abf80.

📒 Files selected for processing (4)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml

---

📝 Walkthrough

Walkthrough

The OLMLifecycleAndCompatibility feature gate now enables only for SelfManaged DevPreviewNoUpgrade and TechPreviewNoUpgrade profiles. The feature matrix reflects this eligibility, and the Default and OKD SelfManagedHA payload manifests list the gate as disabled.

Possibly related PRs

• openshift/api#2920: Modifies the same feature-gate logic and SelfManagedHA manifests with opposite enablement changes.

Suggested reviewers: everettraven, vr4manta, sadasu

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly reflects the main change: an experimental revert of #2920 for a payload upgrade test.
Description check	✅ Passed	The description is directly related to the revert and explains the upgrade-failure validation goal.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	No test files or Ginkgo titles were changed; the PR only updates docs, feature-gate code, and payload manifests.
Test Structure And Quality	✅ Passed	PASS — This PR only changes feature-gate metadata/code; no Ginkgo test files were added or modified, so the test-structure checklist is not applicable.
Microshift Test Compatibility	✅ Passed	No new Ginkgo tests were added; the PR only changes feature-gate registration and payload manifests, so MicroShift test compatibility is not implicated.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No Ginkgo e2e tests were added or modified; the PR only changes feature-gate metadata and payload manifests, so the SNO test check is not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	Only feature-gate registrations and manifest lists changed; no pod affinity, node selectors, spread constraints, replicas, or PDBs were introduced.
Ote Binary Stdout Contract	✅ Passed	PR only changes feature-gate metadata and YAML manifests; no main/init/TestMain/suite setup code or stdout writes were added.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	No new or modified Ginkgo/e2e test files were added; only feature-gate metadata and manifests changed.
No-Weak-Crypto	✅ Passed	PR only changes feature-gate matrices/manifests; diff scan found zero added lines with weak-crypto terms or custom crypto patterns.
Container-Privileges	✅ Passed	Touched files only change feature-gate JSON/YAML; no privileged, hostPID/Network/IPC, CAP_SYS_ADMIN, root, or allowPrivilegeEscalation settings appear.
No-Sensitive-Data-In-Logs	✅ Passed	Touched files only change feature-gate metadata; no log statements or sensitive-data fields appear in the diff.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/8cdbc700-8854-11f1-96dd-3a5bf6314f3e-0

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign everettraven for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[redhat-chai-bot]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade 5

[openshift-ci]

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-aws-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/91d3ff90-887f-11f1-9996-b364db4e7190-0

[redhat-chai-bot]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade 5

[openshift-ci]

@redhat-chai-bot: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-upgrade-from-stable-4.22-e2e-azure-ovn-upgrade

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/952cc780-887f-11f1-9bed-b113d6d6121d-0