Skip to content

OCPBUGS-63475: Refresh rendezvous IP selection list - #345

Open
redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:OCPBUGS-63475
Open

redhat-chai-bot wants to merge 1 commit into
openshift:mainfrom
redhat-chai-bot:OCPBUGS-63475

Conversation

@redhat-chai-bot

Copy link
Copy Markdown

What does this pull request do?

Refreshes the host IP list whenever the rendezvous-node IP selection page is entered.

Why is this needed?

The list was populated during UI initialization and remained stale after a user added or changed a static IP through the network configuration flow. Rebuilding the list on page entry makes newly available IPs selectable.

Testing

  • gofmt -l tools/agent_tui/ui/ui.go tools/agent_tui/ui/rendezvous_ip_select.go tools/agent_tui/ui/rendezvous_ip_select_test.go
  • git diff --check
  • go test -count=1 ./tools/agent_tui/ui
  • make lint (golangci-lint 2.11.3; 0 issues)

AI-generated. Review for accuracy.

@mhanss requested via Chai Bot

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 11, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-63475, which is invalid:

  • expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "4.21.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What does this pull request do?

Refreshes the host IP list whenever the rendezvous-node IP selection page is entered.

Why is this needed?

The list was populated during UI initialization and remained stale after a user added or changed a static IP through the network configuration flow. Rebuilding the list on page entry makes newly available IPs selectable.

Testing

  • gofmt -l tools/agent_tui/ui/ui.go tools/agent_tui/ui/rendezvous_ip_select.go tools/agent_tui/ui/rendezvous_ip_select_test.go
  • git diff --check
  • go test -count=1 ./tools/agent_tui/ui
  • make lint (golangci-lint 2.11.3; 0 issues)

AI-generated. Review for accuracy.

@mhanss requested via Chai Bot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 9313747a-856d-434e-ad94-f50453317a80


Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from bfournie and rwsu September 11, 2026 10:59
@openshift-ci

openshift-ci Bot commented Sep 11, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: redhat-chai-bot
Once this PR has been reviewed and has the lgtm label, please assign rwsu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mhanss

mhanss commented Sep 16, 2026

Copy link
Copy Markdown

/verified by @mhanss

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 16, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@mhanss: This PR has been marked as verified by @mhanss.

Details

In response to this:

/verified by @mhanss

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants