OCPBUGS-63475: Refresh rendezvous IP selection list - #345
redhat-chai-bot wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@redhat-chai-bot: This pull request references Jira Issue OCPBUGS-63475, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: redhat-chai-bot The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
cfd81d0 to
a8d964f
Compare
|
/verified by @mhanss |
|
@mhanss: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What does this pull request do?
Refreshes the host IP list whenever the rendezvous-node IP selection page is entered.
Why is this needed?
The list was populated during UI initialization and remained stale after a user added or changed a static IP through the network configuration flow. Rebuilding the list on page entry makes newly available IPs selectable.
Testing
gofmt -l tools/agent_tui/ui/ui.go tools/agent_tui/ui/rendezvous_ip_select.go tools/agent_tui/ui/rendezvous_ip_select_test.gogit diff --checkgo test -count=1 ./tools/agent_tui/uimake lint(golangci-lint2.11.3; 0 issues)AI-generated. Review for accuracy.
@mhanss requested via Chai Bot