Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Fixes #3478. Part of #2819.
AssetsFacade.getResultsmodified caller-owned queries when applying engine scope and storage defaults. Reusing an asset-scoped query through a realm or global engine could retain the earlier asset-path restriction. Each execution now uses an independentAssetQuerycopy, preserving the caller's filters and preventing later caller edits from changing an earlier execution's query.Add a copy constructor and copying support for nested logical groups, attribute predicates, metadata, paths and mutable values. Preserve null versus empty selections, numeric precision and predicate types. Built-in value predicates are copied explicitly; custom serializable predicates use Java serialization. The facade applies its projection to the copy, so it no longer needs to restore the caller's projection afterwards.
Regression tests cover query reuse across global, realm and asset engines, storage-added defaults, nested mutation isolation, empty selections and predicate copying. Enable
manager/src/test/groovyalongside the existing test directory. Path-filter preservation remains tracked separately in #3479.Validation:
./gradlew --offline --no-daemon :model:test :manager:test— all 393 tests passed (57 model, 336 manager). Regression tests were added and confirmed failing before the fix.Checklist