Repository navigation
Conversation
MartinaeyNL
left a comment
MartinaeyNL
left a comment
There was a problem hiding this comment.
Initial review by an AI agent
Thanks! The header comments are excellent — I traced the deployment.yml and deploy.yml ones back through deploy.sh, process-cicd-json and Do deployments, and the precedence / secret-handling / env-file claims all check out.
One thing before merge: the diff isn't only comments. custom-staging.yml now deploys, custom-install-dist.yml and custom-deploy.yml are new workflows, and custom-review.yml / custom-staging.yml switch build workflows — none of which is in the changelog. Two commits are also still called wip.
| if: ${{ !failure() && !cancelled() && needs.detect-changes.outputs.deploys != '' }} | ||
| uses: "./.github/workflows/deployment.yml" | ||
| with: | ||
| INPUTS: ${{ inputs.INPUTS }} |
There was a problem hiding this comment.
deployment.yml never reads inputs.INPUTS — its Process inputs step only takes callerInputs when eventName == 'workflow_call', which can't happen. What actually feeds it is github.event.inputs, and on a push trigger there are none.
So this passthrough has no effect as written. Either drop it, or fix that guard in deployment.yml so the plumbing is real.
| type: string | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} |
There was a problem hiding this comment.
github.workflow in a reusable workflow resolves to the caller's workflow name, so this collides with a caller using the same formula by construction — which is what the header warns about. A distinct prefix removes the footgun rather than documenting it.
|
Ekhorn
changed the title
Description
Documents what each environment workflow handles and how the deployment workflow resolves its configuration, in the workflow header comments. Related to openremote/documentation#171; merge that first, since
AGENTS.mdlinks its published page. Problems in the workflows found during review are tracked in #3474.Changelog
deployment.ymlselects deployments and combines secrets, inputs and env filesdeploy.ymlheaderSSH_PASSWORDin theci_cd.ymlheader and.ci_cd/README.md.ci_cd/README.mdat the current workflowsAGENTS.mdChecklist