fix: grade outputs by run kind - #183
Open
danielgaskins wants to merge 1 commit into
Open
danielgaskins wants to merge 1 commit into
danielgaskins wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use Case / Run Evidence
Fixes #180.
The contract grader still required a retired manifest and read every contract output from
bindings/. Current mounted responsibility runs instead declare their topology incompiled-intent.jsonand publish committed outputs throughworld-model/andreceipts/.This could cause a valid mounted run to fail before any clauses were graded. It could also allow an output to receive satisfaction credit without establishing that the output was committed successfully.
Design Boundary
This change updates the standard contract-grader contract and its focused conformance coverage. It does not change contract syntax, VM semantics, filesystem layout, compilation, or host behavior.
Examples
For a mounted responsibility, the grader now resolves each node and its
### Maintainsclauses from compiled intent and source snapshots. It reads output fromworld-model/{node}/and checks the corresponding receipt chain and published version.For a standalone function, the grader reads declared
### Returnsoutputs frombindings/{function}/without requiring mounted-only artifacts.If mounted output exists without trustworthy receipt or version evidence, the affected clause is reported as unevaluable. It cannot receive a satisfied or partially satisfied verdict.
Testing
corepack pnpm exec vitest run tests/open-prose/evals/contract-grader.test.ts --maxWorkers=1corepack pnpm test -- --maxWorkers=1The focused suite passed 7 tests. The full suite passed 308 tests across 20 files.
Residual Risk / Follow-ups
The tests verify that the grader contract follows the documented artifact and scoring rules. They do not execute contract grading through a live Prose Complete host.