New metric: ksim - #75
Merged
Merged
Conversation
rcannood
reviewed
Aug 20, 2025
Co-authored-by: Robrecht Cannoodt <[email protected]>
mumichae
marked this pull request as ready for review
August 29, 2025 10:05
…h_integration into features/ksim
Contributor
|
@mumichae it's good to go! Please check out whenever you have time :) |
mumichae
commented
Sep 24, 2025
mumichae
left a comment
mumichae
left a comment
Collaborator
Author
There was a problem hiding this comment.
Looking good! If you update the metric description, it should be ready to merge
mumichae
commented
Sep 25, 2025
|
|
||
| * Added `metrics/kbet_pg` and `metrics/kbet_pg_label` components (PR #52). | ||
|
|
||
| * Added `metircs/ksim` component (PR #75). |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| * Added `metircs/ksim` component (PR #75). | |
| * Added `metrics/ksim` component (PR #75). |
* Output both `ksim_mean` and `ksim_accept_rate` -- `calc_kSIM()` returns a tuple, so writing it as one value produced a 1x2 `metric_values` array * Add missing `metric_type: embedding`, without which `run_benchmark` filters the metric out * Register `metrics/ksim` in the `run_benchmark` workflow * Drop the tunable arguments in favour of pegasus' defaults (K=25, min_rate=0.9) * Use `meta["cpus"]` instead of every physical core on the node * Align the docker image and pypi dependencies with `metrics/kbet_pg` * Add the `## VIASH START` block, rephrase the descriptions in passive voice, fix the changelog typo
Member
|
LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!