Fix the blockers for the next denbi run - #115
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Sweep of
mainbefore the next full run on de.NBI. Fixes everything that would make a method or metric silently not run, or not build.methods/ligerfailing to build: drop thegithub: welch-lab/RcppPlancinstall, whose cmake step no longer configures. rliger 2.2.1 already imports RcppPlanc (>= 2.0.0) from CRAN, so the line was redundant. Every Build onmaintoday failed on liger and thebuild_mainimage dated from 2025-10-15.viash testgreen locally.methods/condo,methods/drvi,methods/limma_removebatcheffect,methods/seurat_cca,methods/seurat_rpca,methods/stacas,metrics/brasandmetrics/cilisiinrun_benchmark(bothconfig.vsh.yamldependencies and the lists inmain.nf). They were all insrc/and the CHANGELOG, but the workflow never ran them.metric_type: embeddingtometrics/cilisiandmethod_types: [embedding]tomethods/drvi; without those the workflow filter never schedules them. cilisiviash testgreen.methods/scimilarityagpulabel and passuse_gpu=torch.cuda.is_available()toCellEmbedding; it was running CPU-only on a 5-cpu slot. Verified the component end-to-end on the test dataset with the model archive froms3://openproblems-work/cache/(CPU path; no CUDA card here, so the GPU branch is first exercised on denbi).Not in this PR: the flaky Bioconductor index fetches in the R image builds (
unable to access index for repository https://bioconductor.org/packages/3.23/...) that hitbatchelor_*,limma_removebatcheffect,scmerge2andss_stacastoday. viash-actions' build workflow has no retry input, so the only cheap option is re-running the job; all theirbuild_mainimages are fresh as of today.Heads-up: CRAN lists RcppPlanc as "issues need fixing before 2026-08-26". If it gets archived, liger will need the CRAN archive tarball pinned explicitly.
Checklist before requesting a review
I have performed a self-review of my code
Check the correct box. Does this PR contain:
Proposed changes are described in the CHANGELOG.md
CI Tests succeed and look good!