Repository navigation
Conversation
FFrVariableReference::readVariable() extracting the data for a named variable at the current file position. Cosmetic changes in FFrVariableReference::recursiveReadPosData().
Remove copy constructor and assignment operator, rely on default. Add doxy for the FFaMat34 class.
Add doxy for the FFaMat33 class and FFaAlgebra namespace.
Remove the copy constructors and assignment operators that would be equivalent to the implicitly defined ones. Add doxy for the FFaTensor[123] classes.
Make FFaUnitCalculatorProvider constructor and destructor private such that only the friended singelton parent can create/destroy.
FFaUserFuncPlugin, FiUserElmPlugin and FiDeviceFunctionFactory such that only the friended singelton parents can create/destroy.
Make its constructor and destructor private such that only the friended singelton parent can create/destroy.
Remove unneccesary empty constructor and destructor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly adding a lot of (and fixing some) doxygen comments in FFaLib + some very minor fixes/cleaning.
Most importantly, missing implementation of addition/subtraction operators for FaMat34.