Skip to content

build: restore build:packages on turbo 2.10.1+ - #1035

Merged
arbrandes merged 1 commit into
openedx:mainfrom
arbrandes:arbrandes/fix-turbo-package-manager
Aug 30, 2026
Merged

build: restore build:packages on turbo 2.10.1+#1035
arbrandes merged 1 commit into
openedx:mainfrom
arbrandes:arbrandes/fix-turbo-package-manager

Conversation

@arbrandes

Copy link
Copy Markdown
Contributor

Description

make build-packages fails on turbo 2.10.1 and later with package_task_in_single_package_mode, rejecting the //#dev:site root task. turbo 2.10.1 reworked package manager detection, and with no packageManager field it falls back to single-package mode, where //# root tasks are invalid.

Declaring packageManager fixes it. The --dangerously-disable-package-manager-check flag was compensating for the missing field and is what now triggers the fallback, so it comes out too. The lockfile bump takes turbo to an affected version, where this is verified.

Part of openedx/frontend-base#312.

LLM usage notice

Built with assistance from Claude.

@codecov

codecov Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.27%. Comparing base (3971678) to head (ca598b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1035   +/-   ##
=======================================
  Coverage   27.27%   27.27%           
=======================================
  Files           9        9           
  Lines          22       22           
  Branches        1        1           
=======================================
  Hits            6        6           
  Misses         16       16           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@arbrandes
arbrandes force-pushed the arbrandes/fix-turbo-package-manager branch from 15dd8f3 to ca598b6 Compare August 30, 2026 15:39
@arbrandes arbrandes changed the title fix: restore build:packages on turbo 2.10.1+ build: restore build:packages on turbo 2.10.1+ Aug 30, 2026
@arbrandes
arbrandes merged commit abdfc6c into openedx:main Aug 30, 2026
6 checks passed
@arbrandes
arbrandes deleted the arbrandes/fix-turbo-package-manager branch August 30, 2026 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant