feat!: upgrade to frontend-base 2.0 - #1034
Merged
arbrandes merged 2 commits intoAug 29, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1034 +/- ##
=======================================
Coverage 27.27% 27.27%
=======================================
Files 9 9
Lines 22 22
Branches 1 1
=======================================
Hits 6 6
Misses 16 16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Take the peer dependency to the 2.0 prerelease line on the alpha dist-tag, which is where this repository's own main publishes too. The range stays generic rather than naming a specific alpha, since a template should not pin copies of itself to whichever prerelease happened to be current. The app bundles no config, so App.defaultConfig has nothing to hold here. Drop the empty config from the test site's app entry as well: config is the operator's field, and an empty one on an app with no operator config is the wrong shape for a template to teach. The lockfile also takes @openedx/paragon from 23.21.2 to 23.23.0, the floor frontend-base 2.0 requires. BREAKING CHANGE: requires @openedx/frontend-base ^2.0.0-alpha. Closes openedx#1033 Co-Authored-By: Claude <[email protected]>
The Configuration section spoke only of per-app config, which after ADR 0017 is the operator's field, not the app author's. Every new App Repository starts from this README, so it should say which field a bundled default belongs in, and that config is what an operator gets to set. Co-Authored-By: Claude <[email protected]>
arbrandes
force-pushed
the
arbrandes/issue-1033-frontend-base-2.0
branch
from
August 29, 2026 13:53
87c8f1a to
d6c75be
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Takes the
@openedx/frontend-basepeer dependency to^2.0.0-alpha || 0.0.0-dev, part of openedx/frontend-base#299. The range stays generic rather than naming a specific alpha, since a template should not pin copies of itself to whichever prerelease happened to be current. Nothing else was required, as the issue predicted: the template imports nothing fromreact-intl, declares no TypeScript type members for the new semicolon rule to catch, and bundles no config forApp.defaultConfigto hold. Two things came along anyway. The emptyconfigon the test site's app entry goes, since after ADR 0017configis the operator's field. And the lockfile takes@openedx/paragonto 23.23.0, the floor frontend-base 2.0 requires, without whichnpm cifails the peer check.The second commit is the part specific to this repository being a template.
README-template-frontend-app.rstis what every new App Repository starts from, and its Configuration section spoke only of per-appconfig. It now explains howgetAppConfigresolves bundleddefaultConfigbelowcommonAppConfigbelowconfig, and which field a shipped default belongs in.Closes #1033
LLM usage notice
Built with assistance from Claude.