feat: add App.defaultConfig for bundled app config defaults - #298
Open
arbrandes wants to merge 1 commit into
Open
feat: add App.defaultConfig for bundled app config defaults#298arbrandes wants to merge 1 commit into
arbrandes wants to merge 1 commit into
Conversation
This was referenced Aug 28, 2026
arbrandes
requested review from
MaxFrank13,
brian-smith-tcril and
diana-villalvazo-wgu
August 28, 2026 09:33
defaultConfig now holds the author's values and resolves below commonAppConfig, which resolves below config; it is optional, so an app that doesn't set it resolves exactly as before. Co-Authored-By: Claude <[email protected]>
arbrandes
force-pushed
the
arbrandes/default-app-config
branch
from
August 28, 2026 09:34
2f026d3 to
29158d8
Compare
Contributor
|
I do like the idea of adding the new app default config as a way to separate the concerns of "app author wants to set a default for something" and "site operator wants to override a site default for one app." I'm now trying to think through the different configs, and it feels to me like we might be missing one:
I know we have non-app "common" defaults in site config, and maybe that's a better place for anything that would fall into the "???" category to live, but I figured it was worth raising. |
Contributor
Author
That doesn't exist at the level of frontend-base or apps. It's something for the site, and we already have a place for it: commonAppConfig. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
App.configheld two unrelated kinds of value: the defaults an app author bundles with the app, and the configuration an operator supplies throughsite.configor the runtime config API. Because both went through one field, every key an app bundled was a keycommonAppConfigcould never supply, and an operator overriding a single value had to spread the app's existing config back in or silently discard the rest.This adds an optional
App.defaultConfigfor the app author's values.getAppConfigresolves it belowcommonAppConfig, which resolves belowconfig. The two fields are held separately, so operator-supplied configuration, including anything arriving via the runtime config API, can never write into an app's bundled defaults.The field is additive: an app that does not set it resolves exactly as it does today. Nothing in this repository bundles app defaults, so there was nothing to migrate. The migration how-to now points app authors at
defaultConfig, and ADR 0017 records the decision.Closes #268.
LLM usage notice
Built with assistance from Claude.